Closed
Bug 1153193
Opened 9 years ago
Closed 9 years ago
Share overlay is displayed when tapping on paper plane icon from context menu
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox38 verified, firefox39 verified, firefox40 verified)
VERIFIED
FIXED
Firefox 40
People
(Reporter: csuciu, Assigned: mcomella)
References
Details
Attachments
(1 file, 1 obsolete file)
Steps: 1. Set up sync 2. Open Firefox menu and tap on Quick share button 3. Tap on "Send to other devices" 4. Go to news.google.com 5. Long tap on a link then tap on the paper plane icon from quick share context menu Expected: "Send to devices" list is displayed. This happens if you tap on the paper plane icon from Firefox menu Actual: "Share overlay" is displayed
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → michael.l.comella
Assignee | ||
Comment 1•9 years ago
|
||
/r/6875 - Bug 1153193 - Add EXTRA_DEVICES_ONLY flag to share intents. r=rnewman Pull down this commit: hg pull -r 32c381257f6c8d5f78fbe0ef00aaa07a9ecd0c5a https://reviewboard-hg.mozilla.org/gecko/
Attachment #8590885 -
Flags: review?(rnewman)
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8590885 [details] MozReview Request: bz://1153193/mcomella /r/6875 - Bug 1153193 - Add EXTRA_DEVICES_ONLY flag to share intents. r=rnewman Pull down this commit: hg pull -r 63fd4c7ebfa43ed3f2f7fc3d0ef9809a5458aa9f https://reviewboard-hg.mozilla.org/gecko/
Assignee | ||
Comment 3•9 years ago
|
||
I don't think it's limited to quick share.
Summary: Share overlay is displayed when tapping on paper plane icon from quick share context menu → Share overlay is displayed when tapping on paper plane icon from context menu
Comment 4•9 years ago
|
||
Comment on attachment 8590885 [details] MozReview Request: bz://1153193/mcomella https://reviewboard.mozilla.org/r/6873/#review5745 Ship It!
Attachment #8590885 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/76f43056ec5c
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8590885 [details] MozReview Request: bz://1153193/mcomella Approval Request Comment [Feature/regressing bug #]: bug 1122302 [User impact if declined]: Users who select "Send to other devices" from the context menu or about:reader will be given the share dialog meant for external applications (with extra options) rather than the one for internal applications [Describe test coverage new/current, TreeHerder]: Tested locally on my N4 [Risks and why]: Low - we add an extra to the share intent sent by the context menu and about:reader which is ignored by applications that do not handle the extra. In the share dialog, we use this extra to show the internal dialog, rather than the external one. Worst case, this intent (which is returned from a generic getShareIntent method) is used in more places than I thought and we show the internal dialog when we meant to show the external (however, I don't know why we'd ever want to show the external dialog internally). Otherwise, fairly harmless because it'll be ignored if we don't handle it. [String/UUID change made/needed]: None
Attachment #8590885 -
Flags: approval-mozilla-beta?
Attachment #8590885 -
Flags: approval-mozilla-aurora?
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/76f43056ec5c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Updated•9 years ago
|
Flags: qe-verify+
Comment 8•9 years ago
|
||
Comment on attachment 8590885 [details]
MozReview Request: bz://1153193/mcomella
Should be in 38 beta 4.
Attachment #8590885 -
Flags: approval-mozilla-beta?
Attachment #8590885 -
Flags: approval-mozilla-beta+
Attachment #8590885 -
Flags: approval-mozilla-aurora?
Attachment #8590885 -
Flags: approval-mozilla-aurora+
Reporter | ||
Comment 11•9 years ago
|
||
Verified as fixed on Beta 38.0b4, latest Nightly 40.0a1 and latest Aurora, 39.0a2
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 12•9 years ago
|
||
Attachment #8590885 -
Attachment is obsolete: true
Attachment #8620015 -
Flags: review+
Assignee | ||
Comment 13•9 years ago
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•