Share overlay is displayed when tapping on paper plane icon from context menu

VERIFIED FIXED in Firefox 38

Status

()

defect
VERIFIED FIXED
4 years ago
10 months ago

People

(Reporter: csuciu, Assigned: mcomella)

Tracking

40 Branch
Firefox 40
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox38 verified, firefox39 verified, firefox40 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

4 years ago
Steps:
1. Set up sync
2. Open Firefox menu and tap on Quick share button 
3. Tap on "Send to other devices" 
4. Go to news.google.com
5. Long tap on a link then tap on the paper plane icon from quick share context menu

Expected: "Send to devices" list is displayed. This happens if you tap on the paper plane icon from Firefox menu

Actual: "Share overlay" is displayed
Assignee: nobody → michael.l.comella
/r/6875 - Bug 1153193 - Add EXTRA_DEVICES_ONLY flag to share intents. r=rnewman

Pull down this commit:

hg pull -r 32c381257f6c8d5f78fbe0ef00aaa07a9ecd0c5a https://reviewboard-hg.mozilla.org/gecko/
Attachment #8590885 - Flags: review?(rnewman)
Comment on attachment 8590885 [details]
MozReview Request: bz://1153193/mcomella

/r/6875 - Bug 1153193 - Add EXTRA_DEVICES_ONLY flag to share intents. r=rnewman

Pull down this commit:

hg pull -r 63fd4c7ebfa43ed3f2f7fc3d0ef9809a5458aa9f https://reviewboard-hg.mozilla.org/gecko/
I don't think it's limited to quick share.
Summary: Share overlay is displayed when tapping on paper plane icon from quick share context menu → Share overlay is displayed when tapping on paper plane icon from context menu
Comment on attachment 8590885 [details]
MozReview Request: bz://1153193/mcomella

https://reviewboard.mozilla.org/r/6873/#review5745

Ship It!
Attachment #8590885 - Flags: review?(rnewman) → review+
Comment on attachment 8590885 [details]
MozReview Request: bz://1153193/mcomella

Approval Request Comment
[Feature/regressing bug #]: bug 1122302
[User impact if declined]:
  Users who select "Send to other devices" from the context menu or about:reader will be given the share dialog meant for external applications (with extra options) rather than the one for internal applications

[Describe test coverage new/current, TreeHerder]:
  Tested locally on my N4
[Risks and why]: 
  Low - we add an extra to the share intent sent by the context menu and about:reader which is ignored by applications that do not handle the extra. In the share dialog, we use this extra to show the internal dialog, rather than the external one. Worst case, this intent (which is returned from a generic getShareIntent method) is used in more places than I thought and we show the internal dialog when we meant to show the external (however, I don't know why we'd ever want to show the external dialog internally). Otherwise, fairly harmless because it'll be ignored if we don't handle it.

[String/UUID change made/needed]: None
Attachment #8590885 - Flags: approval-mozilla-beta?
Attachment #8590885 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/76f43056ec5c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Flags: qe-verify+
Comment on attachment 8590885 [details]
MozReview Request: bz://1153193/mcomella

Should be in 38 beta 4.
Attachment #8590885 - Flags: approval-mozilla-beta?
Attachment #8590885 - Flags: approval-mozilla-beta+
Attachment #8590885 - Flags: approval-mozilla-aurora?
Attachment #8590885 - Flags: approval-mozilla-aurora+
Reporter

Comment 11

4 years ago
Verified as fixed on Beta 38.0b4, latest Nightly 40.0a1 and latest Aurora, 39.0a2
Attachment #8590885 - Attachment is obsolete: true
Attachment #8620015 - Flags: review+

Comment 14

10 months ago
Based on comment 11 I will remove the qe-verify flag.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.