Closed Bug 1153220 Opened 9 years ago Closed 9 years ago

[Desktop]Elements from Header are not correctly aligned in the new nav bar

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Avenir
x86_64
Windows 7
defect

Tracking

(Not tracked)

VERIFIED FIXED
2015-04-21

People

(Reporter: vcarciu, Assigned: kngo)

References

Details

Prerequisites:
Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0

Steps to reproduce:
1.Go to https://marketplace-dev.allizom.org/ with new nav bar enabled

Expected results:
All elements on header are aligned according to the mocks(equal distances between all buttons and icons : http://screencast.com/t/ZXSYlddfMDju) 

Actual results:
1.Home icon, Settings and search magnifier are in bottom corners, not aligned with the other elements
2.Search, Categories blue background should not be displayed on the entire width of the page

Please see screencast for this bug : http://screencast.com/t/arAi5sBdV
Assignee: nobody → kngo
Some questions on what is expected:

For 1., what elements should they be aligned with?

For 2., the mocks I have show that the Search and Categories dropdown should take the full width of the page. Is that not correct?
gotta CC or needinfo people.  ni?pwalm for comment 1
Flags: needinfo?(pwalmsley)
Gonna needinfo Victor as I'm not sure what the exact issues are.
Flags: needinfo?(pwalmsley) → needinfo?(vcarciu)
https://github.com/mozilla/fireplace/pull/1136 This might fix
Status: NEW → RESOLVED
Closed: 9 years ago
Priority: -- → P3
Resolution: --- → FIXED
Target Milestone: --- → 2015-04-21
I mean that after reading mocks , I think that we should have same distance between all ements of header : http://screencast.com/t/KTu1teUWj3A
Flags: needinfo?(vcarciu)
Yeah, the spacing between the nav elements should be balanced more evenly, as reflected in the mocks.
(In reply to Philip [:pwalm] from comment #6)
> Yeah, the spacing between the nav elements should be balanced more evenly,
> as reflected in the mocks.

So , should we re-open this bug?
Flags: needinfo?(pwalmsley)
Just looked at it, everything is a-ok now. :D
Flags: needinfo?(pwalmsley)
Marking bug as verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.