1153253 - move nsImageBoxFrame::mRequestRegistered to pack better with other members

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Nathan Froyd [:froydnj]]

Given alignment requirements on most platforms, there will be at least 3
bytes of padding after mRequestRegistered in its current location, and
at least one unused byte at the end of the structure.  We can move
mRequestRegistered after mLoadFlags so that it packs properly with the
boolean flags already there for less wasted space.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: move nsImageBoxFrame::mRequestRegistered to pack better with other members

Noticed while doing a bit of other work.

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8590861 [details] [diff] [review]
move nsImageBoxFrame::mRequestRegistered to pack better with other members

Please also update the init list here to keep it in the right order (or else you'll get a compile warning):
 http://mxr.mozilla.org/mozilla-central/source/layout/xul/nsImageBoxFrame.cpp#147

The "mRequestRegistered(false)" and "mLoadFlags(nsIRequest::LOAD_NORMAL)" lines just need to be swapped, I think.

r=me with that

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Daniel Holbert [:dholbert] from comment #2)
> Please also update the init list here to keep it in the right order (or else
> you'll get a compile warning):
>  http://mxr.mozilla.org/mozilla-central/source/layout/xul/nsImageBoxFrame.
> cpp#147

Thanks for pointing this out!  Saved me from a "oh, that patch is trivial, doesn't need real try testing" incident with the sheriffs.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4f757be7142f