1153259 - use NS_NewByteInputStream in zipwriter to reduce do_CreateInstance overhead

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nathan Froyd [:froydnj]]

Profiling startup shows that we have several thousand calls to:

  do_CreateInstance("@mozilla.org/io/string-input-stream;1")

and virtually all of them are located in the zipwriter code.  We can
create string input streams much more directly with
NS_NewByteInputStream, which avoids a lot of overhead associated with
do_CreateInstance.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: use NS_NewByteInputStream in zipwriter to reduce do_CreateInstance overhead

Not sure if you are exactly the right person to review, but ISTR you reviewing
things in zipwriter/ before.  Feel free to forward on to somebody else.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8590869 [details] [diff] [review]
use NS_NewByteInputStream in zipwriter to reduce do_CreateInstance overhead

Review of attachment 8590869 [details] [diff] [review]:
-----------------------------------------------------------------

I'm comfortable with reviewing this. Nice catch!

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eee4e1faf745

Comment 4

[Vladan Djeric (:vladan)]

No Talos improvements :/
http://graphs.mozilla.org/graph.html#tests=[[83,131,25]]&sel=none&displayrange=7&datatype=geo