1153267 - don't NS_ADDREF outparams when we can use smart pointers instead

Status: RESOLVED FIXED

(Core :: General, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: part 1 - use smart-pointer .forget() instead of NS_ADDREF+assign

If we're already holding something in a smart pointer, there's no need to
NS_ADDREF it on the way out, we can just .forget() into the outparam.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: part 2 - use smart pointers instead of manual NS_ADDREF'ing outparams

This cleans up several easy-to-handle usages of NS_ADDREF'ing raw pointers into
outparams by using smart pointers instead.

Comment 3

[(no longer active)]

Comment on attachment 8590878 [details] [diff] [review]
part 1 - use smart-pointer .forget() instead of NS_ADDREF+assign

Review of attachment 8590878 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/streamconv/nsStreamConverterService.cpp
@@ +550,2 @@
>          rv = listener->AsyncConvertData(aFromType, aToType, aListener, aContext);
> +        listener.forget(_retval);

Hmm, this changes the semantics of the code slightly, but hopefully that's ok...

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3fb0310f5f49
https://hg.mozilla.org/mozilla-central/rev/d7d35bcd761d
https://hg.mozilla.org/mozilla-central/rev/914fa009e6c7