1153300 - Consider returning user to an about:home tab after closing last tab

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

Akin to Android, after a user clears all open tabs, the only way out of the tab drawer currently is to open another new tab (about:home)

Comment 1

[Connor Smith]

This can be changed by getting an add-on, I have an add on of New Tab Homepage
https://addons.mozilla.org/en-US/firefox/addon/new-tab-homepage/?src=ss

Comment 2

[Aaron Train [:aaronmt]]

(In reply to Connor Smith from comment #1)
> This can be changed by getting an add-on, I have an add on of New Tab
> Homepage
> https://addons.mozilla.org/en-US/firefox/addon/new-tab-homepage/?src=ss

This is filed against Firefox for iOS.

Comment 3

[Aaron Train [:aaronmt]]

https://github.com/mozilla/firefox-ios/pull/352

Comment 4

[Wesley Johnston (:wesj)]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/438

Hey darrin, this implements add (and selecting) a new tab when the last one is closed. Some cleanup to do, but I wanted your feedback before I dug into it.

Comment 5

[Darrin Henein [:darrin]]

Comment on attachment 8603423 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/438

Seems like a good start, I'm seeing some weird behaviour though... i.e. I have 3 tabs open, closing the 2nd/3rd one opens up one of the other tabs as soon as it is deleted... etc.

Might also need a slight delay between deleting the last tab and the new one transitioning in?

Comment 6

[Wesley Johnston (:wesj)]

Comment on attachment 8603423 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/438

I updated this to show the animation's sequentially. i.e. we'll add/remove the tab, and the select it when that animation is done. Also added that to the newTab button's animation (do you want that darrin?)

Comment 7

[Brian Nicholson (:bnicholson)]

Comment on attachment 8603423 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/438

Looks good, though I'm skeptical about the lines being removed in hideHomePanelController. Waiting for comments about those (either from you or the people pinged there) before switching to r+.

Comment 8

[Brian Nicholson (:bnicholson)]

Comment on attachment 8603423 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/438

r=me with merge deletions reverted.

Comment 9

[Wesley Johnston (:wesj)]

https://github.com/mozilla/firefox-ios/pull/438