1153331 - Move phonebook code to GitHub

Status: RESOLVED FIXED

(Webtools Graveyard :: Phonebook, defect)

Description

[tofumatt [:tofumatt]]

To increase ease-of-contribution and bring it in line with other Mozilla webdev projects, we should move the internal phonebook from SVN to Git and host it on Github.

I can take care of the checkout and import into Git, as well as the push to github. Need IT advice/sign-off on changing what gets pulled/how this is deployed once it's on git not SVN.

Comment 1

[Fred Wenzel [:wenzel]]

Rob, any objections? We did the same thing with the PTO app -- copy to github including history, then move the svn trunk out of the way to tags/oldtrunk to avoid confusion.

On your end you'd have to redeploy from git though, which shouldn't be hard, but will take a few minutes.

Comment 2

[Rob Tucker [:rtucker]]

There already exists: https://github.com/lonnen/phonebook
The only hurdle will be to get webops to change the deploy script to pull from GH. I'm 100% onboard though

Comment 3

[Shyam Mani [:fox2mike]]

(In reply to Rob Tucker [:rtucker] from comment #2)
> There already exists: https://github.com/lonnen/phonebook
> The only hurdle will be to get webops to change the deploy script to pull
> from GH. I'm 100% onboard though

This shouldn't be a hurdle :) I'll take a stab at the scripts and see what work needs to be done.

Comment 4

[Fred Wenzel [:wenzel]]

(In reply to Rob Tucker [:rtucker] from comment #2)
> There already exists: https://github.com/lonnen/phonebook

Sounds good. Well lonnen himself calls that an outdated mirror, I'd be more comfortable recloning (and to mozilla), but anyway.

(In reply to Shyam Mani [:fox2mike] from comment #3)
> This shouldn't be a hurdle :) I'll take a stab at the scripts and see what
> work needs to be done.

Thank you. Meanwhile one of us can do the re-cloning (perhaps me, because I am not sure tofumatt's internet connection is currently beefy enough for a lengthy svn pull)

Comment 5

[Lonnen :lonnen]

I made a clone a few months back. It is likely only a patch or two out of date. https://github.com/lonnen/phonebook

Comment 6

[tofumatt [:tofumatt]]

My connection can handle an SVN pull as long as it's not 9pm EEST ;-)

If the SVN version is the canonical repo I say we just take that; my PR to :lonnen's branch I can send again once we put it on GitHub under mozilla/

Comment 7

[Lonnen :lonnen]

https://github.com/mozilla/phonebook

moved. if it updates on svn before we change the deploy scripts we'll have to do this again

Comment 8

[Fred Wenzel [:wenzel]]

Who with an active svn commit bit can push /projects/phonebook/trunk to /projects/phonebook/tags/oldtrunk for us to avoid confusion going forward?

Comment 9

[Reed Loden [:reed]]

(In reply to Fred Wenzel [:wenzel] from comment #8)
> Who with an active svn commit bit can push /projects/phonebook/trunk to
> /projects/phonebook/tags/oldtrunk for us to avoid confusion going forward?

r140094

Comment 10

[Fred Wenzel [:wenzel]]

Marvelous thanks. The code is moved and ready to roll. I could normally close this bug, but I figure we should keep it open until the deploy scripts are also updated, yes?

Comment 11

[Shyam Mani [:fox2mike]]

(In reply to Fred Wenzel [:wenzel] from comment #10)
> Marvelous thanks. The code is moved and ready to roll. I could normally
> close this bug, but I figure we should keep it open until the deploy scripts
> are also updated, yes?

I can modify the deploy scripts, this shouldn't be too hard if someone can help with the correct git commands :) What are the next steps?

Comment 12

[Lonnen :lonnen]

`git clone https://github.com/mozilla/phonebook.git`, I suppose

Comment 13

[tofumatt [:tofumatt]]

Yeah, that's all that would be needed. For what it's worth, :fox2mike, I updated the Mana page (https://mana.mozilla.org/wiki/display/websites/phonebook.mozilla.org) with the new code location/checkout procedure.

Comment 14

[Eric Ziegenhorn :ericz]

Updated our scripts on the generic cluster to pull from git for prod, stage and dev phonebook sites.

Comment 15

[Lonnen :lonnen]

I'm pretty sure this is done.