115334 - A few straggler .mcp files still in the tree

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Håkan Waara]

Here are the ones I found only in mailnews/:

mailnews/addrbook/macbuild/msgAddrbook.mcp
mailnews/base/macbuild/msgCore.mcp
mailnews/base/util/macbuild/msgUtil.mcp
mailnews/db/mork/mork/macbuild/mork.mcp
mailnews/mime/cthandlers/calendar/macbuild/calendar.mcp
mailnews/mime/emitters/macbuild/mimeEmitter.mcp
mailnews/mime/macbuild/mimeIDL.mcp
mailnews/mime/macbuild/mime.mcp

Note that this is only for the mailnews module. I bet there are a bunch of them 
still alive in other directories!

Comment 1

[hacker formerly known as [e-mail]]

Over to jj.

Comment 2

[Jon Granrose]

I saw someone removing a bunch of these this morning.  I forget who but remember
them mentioning brade so cc'ing her here.

Comment 3

[Håkan Waara]

alecf removed some.  but there are still many left.

Comment 4

[Conrad Carlen (not reading bugmail)]

  There are some that were left because they were not referenced by the build
scripts in any config. That means they are either dead or not yet working, so
they were not converted to XML. If somebody had added a project with the
intention of adding it to the build at some point, I'd rather have the file
still in the tree than throw away somebody's work.
  BTW, there are two .mcp files which I can't get rid of in
mozilla/xpfe/bootstrap/macbuild because there has been a lock in that directory
since I originally landed this stuff. leaf, can you see what's up with this lock?

Comment 5

[Simon Fraser [no longer active]]

mozilla/xpfe/bootstrap/macbuild

Are you sure that's a CVS lock, and not the Finder showing you the folder as a 
package?

Comment 6

[Conrad Carlen (not reading bugmail)]

There's a "waiting for cvs user's lock..." in the log window.

Comment 7

[J.J. Enser]

based on email conversation with some Mac engineers, we need to keep these .mcp
files around for a while.

Comment 8

[Simon Fraser [no longer active]]

We do?

Comment 9

[J.J. Enser]

isn't it what Conrad said at a recent macdev meeting ? some of the mcp files are
not part of the "standard" build and should remain in the tree, that's what I
understood.
I think he removed the rest. Conrad?

Comment 10

[Conrad Carlen (not reading bugmail)]

  Any .mcp which has a corresponding .xml, needs to be removed. Like I said in
comment #4, I couldn't remove some of those at the time due to cvs locks.
Others, I may have missed - my bad. Anyway, they should go.
  Also, there are lots of .mcp files that were not referenced by the build
scripts so were not converted. I don't know the status of these projects, but
wouldn't delete them without knowing. Somebody should compile a list of orphan
.mcp files, circulate it widely, and ask what's still useful.  

Comment 11

[Jon Granrose]

how many unconverted mcp files are we talking about?  if we cvs remove all the
remaining .mcp files, doesn't that mean they get put in the attic and can be
resurrected if it turns out someone needs them?

Comment 12

[J.J. Enser]

since I need to scan the tree for "removable" .mcp files, I might as well
collect the list of those which haven't been converted to XML and submit that
list for review to macdev/mozilla-mac groups.

Comment 13

[Conrad Carlen (not reading bugmail)]

Hang on. I've got lists coming up.

Comment 14

[Conrad Carlen (not reading bugmail)]

Attachment: .mcp files for which there is an .xml file - can be removed

Comment 15

[Conrad Carlen (not reading bugmail)]

Attachment: files which were never converted

Comment 16

[Conrad Carlen (not reading bugmail)]

Comment on attachment 65634 [details]
.mcp files for which there is an .xml file - can be removed

scratch this one from the list:
>./extensions/xml-rpc/macbuild/_xml-rpcIDL.mcp

Comment 17

[J.J. Enser]

Thanks Conrad. The list of "unconverted" .mcp files is pretty long!

Simon, can you review attachment #65634 [details] (converted to xml) before I cvs remove
them (will do so on the trunk after 0.9.8 branch is cut)

Comment 18

[Mike Pinkerton (not reading bugmail)]

--> ccarlen per our aim conversation

Comment 19

[Peter Van der Beken [:peterv]]

Comment on attachment 65636 [details]
files which were never converted

>./extensions/irc/macbuild/irc.mcp
>./extensions/irc/macbuild/ircIDL.mcp

These are junk, can be cvs removed together with
./extensions/irc/macbuild/ircPrefix.h
./extensions/irc/macbuild/ircPrefixDebug.h

>./extensions/p3p/macbuild/p3p.mcp

This one is in the wrong list, see
http://lxr.mozilla.org/seamonkey/source/extensions/p3p/macbuild/p3p.xml

>./intl/uconv/macbuild/ucvmath.mcp

http://lxr.mozilla.org/seamonkey/source/intl/uconv/macbuild/ucvmath.xml

>./js/macbuild/XPConnect.mcp
>./js/macbuild/XPCShell.mcp

http://lxr.mozilla.org/seamonkey/source/js/macbuild/XPConnect.xml
http://lxr.mozilla.org/seamonkey/source/js/macbuild/XPCShell.xml

>./modules/libimg/macbuild/mng.mcp

http://lxr.mozilla.org/seamonkey/source/modules/libimg/macbuild/mng.xml

I haven't gone through the others, but it seems there's some errors in your
lists.

Comment 20

[Adam Lock]

This one looks like junk to me:

./webshell/embed/mac/RaptorShell.mcp

And this one too since the cpp files have moved to mozilla/docshell

./webshell/macbuild/webshell.mcp

Comment 21

[Conrad Carlen (not reading bugmail)]

Attachment: .mcp files for which there is an .xml - take2

This list should be accurate. It was made in this way:

% find . ! -name "_*" -name "*.mcp" > mcps.txt
In mcps.txt, replaced all occurances of ".mcp" with ".xml"
% xargs < mcps.txt file > stats.txt
In stat.txt, extracted the lines on which the stat succeeded, replaced ".xml"
with ".mcp", and cleaned that up

Comment 22

[Conrad Carlen (not reading bugmail)]

If you search MozillaBuildList.pm, the only .mcps are on commented lines, except
for a lib in CodeWarrior which we build, so it's safe to yank them. JJ, Simon,
can I get review on removing this list?

Comment 23

[Conrad Carlen (not reading bugmail)]

JJ, Simon, Can you r/sr removing the list of files in attachment 67444 [details]?

Comment 24

[Simon Fraser [no longer active]]

sr=sfraser for removal of all except ./xpfe/bootstrap/macbuild/StaticMerge.mcp, 
which I will soon need to hack on.

Comment 25

[Conrad Carlen (not reading bugmail)]

Simon, wouldn't you want to hack on ./xpfe/bootstrap/macbuild/StaticMerge.xml or
at least import that into a project, hack on it, and then back to xml?

Comment 26

[Simon Fraser [no longer active]]

I guess. nuke the .mcp then.

Comment 27

[J.J. Enser]

Comment on attachment 67444 [details]
.mcp files for which there is an .xml - take2

r=jj

note: /extensions/p3p/macbuild/ checks out empty for me, so I couldn't verify
the existence of p3p.xml

Comment 28

[Conrad Carlen (not reading bugmail)]

All .mcps for which there's an .xml are removed - except for NSPR20PPC.mcp. As
for  the remaining 69 .mcp files, I don't think it's my bug.

Comment 29

[Phil Ringnalda (:philor)]

I was *so* expecting to be saying "but over the last seven years, they've finally disappeared." Sadly, not quite - LDAP still has one, and even mozilla-central has one, in what I think is the never-has-been-built /xpcom/tests/StringFactoringTests/

Comment 30

[Phil Ringnalda (:philor)]

Attachment: rm xpcom/tests/StringFactoringTests/*

Doesn't look like StringFactoringTests were ever built by default, but they would have stopped working at all between 0.6 and 0.9.4, since that's when half the stuff in the CPPSRCS went away.

Comment 31

[Phil Ringnalda (:philor)]

Actually, I'll call http://hg.mozilla.org/mozilla-central/rev/445b97593ef7 good enough: LDAP's a world of its own, and that whole directory looks like it's a time capsule of long-dead things.