Closed Bug 1153349 Opened 9 years ago Closed 9 years ago

URL bar buttons disappear after rotation

Categories

(Firefox for iOS :: Browser, defect)

All
iOS 8
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fennec + ---

People

(Reporter: bnicholson, Assigned: sleroux)

References

Details

Attachments

(1 file)

47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review
STR:
1) Rotate the phone to landscape orientation.
2) Tap the URL bar to open editing mode.
3) Rotate the phone to portrait orientation.
4) Click Cancel to leave editing mode.
5) Rotate the phone to landscape orientation.

After these steps, the back/forward/reload buttons are gone, with just an empty space there instead.
tracking-fennec: ? → +
Assignee: nobody → sleroux
Attached file PR
Attachment #8603348 - Flags: review?(bnicholson)
Comment on attachment 8603348 [details] [review]
PR

\o/ for autolayout!
Attachment #8603348 - Flags: review?(bnicholson) → review+
Thanks for the review! Ya autolayout is pretty great for animation stuff. I feel like a lot of bugs we'd see in different orientations would be caused by the transforms we're doing.
Yeah, I agree -- I think we're also directly tweaking frames a bit too much in some places. Autolayout can really help simplify UI logic.

Merged.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: