Closed
Bug 1153392
Opened 9 years ago
Closed 9 years ago
Use the current timestamp if the software vsync thread is late
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: mchang, Assigned: mchang)
Details
(Whiteboard: gfx-noted)
Attachments
(1 file)
|
983 bytes,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
We have a bug with the software vsync source at [1]. If the software vsync thread is delayed for some reason, and we post a task immediately, we still use the old vsync timestamp. The next vsync is already in the past. Just use Now(). [1] https://dxr.mozilla.org/mozilla-central/source/gfx/thebes/SoftwareVsyncSource.cpp?from=SoftwareVsyncSource.cpp#118
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → mchang
Status: NEW → ASSIGNED
Whiteboard: gfx-noted
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8591035 -
Flags: review?(bugmail.mozilla)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8591035 [details] [diff] [review] Use current timestamp is the software vsync thread is late Review of attachment 8591035 [details] [diff] [review]: ----------------------------------------------------------------- I hope this doesn't happen very often...
Attachment #8591035 -
Flags: review?(bugmail.mozilla) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #2) > Comment on attachment 8591035 [details] [diff] [review] > Use current timestamp is the software vsync thread is late > > Review of attachment 8591035 [details] [diff] [review]: > ----------------------------------------------------------------- > > I hope this doesn't happen very often... Yeah right now I only see it on b2g boot up - https://hg.mozilla.org/integration/mozilla-inbound/rev/859c11169646
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/859c11169646
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•