Closed Bug 1153403 Opened 5 years ago Closed 5 years ago

Don't allow dialogs to resize if they weren't resizable in the old preferences

Categories

(Firefox :: Preferences, defect)

defect
Not set
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 40
Iteration:
40.2 - 27 Apr
Tracking Status
firefox37 --- unaffected
firefox38 --- verified
firefox38.0.5 --- fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: alice0775, Assigned: jaws)

References

Details

Attachments

(1 file)

Bug 1043612 has been landed.
However, the following in-content subdialogs do not remember its size.

* content > Fonts & Colors > Advanced...
* content > Languages > Choose...

Persistence of the size of the Fonts subdialog is useful for ja locale.
See Bug 1148923 [ja] Subdialog default width of in-content preferences is too narrow in ja locale
Those dialogs don't have the persist attribute specified on the <window>, therefore they don't get persisted. We could look in to changing that though.

http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/fonts.xul
http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/languages.xul
Summary: Persist the size of resizable in-content subdialogs → Add the persist attribute to resizable subdialogs that are lacking it
Looking at this more, these dialogs don't resize well and weren't designed to be resizable.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Iteration: --- → 40.2 - 27 Apr
Points: --- → 1
Summary: Add the persist attribute to resizable subdialogs that are lacking it → Don't allow dialogs to resize if they weren't resizable in the old preferences
Attached patch PatchSplinter Review
Attachment #8592210 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8592210 [details] [diff] [review]
Patch

Review of attachment 8592210 [details] [diff] [review]:
-----------------------------------------------------------------

Sold!
Attachment #8592210 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/integration/fx-team/rev/0e0d984f606c
Flags: qe-verify-
Flags: firefox-backlog+
OS: Windows 7 → All
Hardware: x86_64 → All
https://hg.mozilla.org/mozilla-central/rev/0e0d984f606c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Did we want to uplift this?
Flags: needinfo?(jaws)
Comment on attachment 8592210 [details] [diff] [review]
Patch

Yeah, we should uplift this.

Approval Request Comment
[Feature/regressing bug #]: in-content preferences, shipping in v38
[User impact if declined]: some dialogs are resizable that weren't resizable before and they don't scale with the resizing
[Describe test coverage new/current, TreeHerder]: manual testing, been on m-c for over a week 
[Risks and why]: very low risk, just disables the resizing of only three dialogs
[String/UUID change made/needed]: none
Flags: needinfo?(jaws)
Attachment #8592210 - Flags: approval-mozilla-beta?
Attachment #8592210 - Flags: approval-mozilla-aurora?
Comment on attachment 8592210 [details] [diff] [review]
Patch

I think this UI polish bug is safe and simple enough to take late in Beta. Beta+ Aurora+

ni Florin to add in-content pref UI resizing to his team's list for exploratory testing if time permits.
Flags: needinfo?(florin.mezei)
Attachment #8592210 - Flags: approval-mozilla-beta?
Attachment #8592210 - Flags: approval-mozilla-beta+
Attachment #8592210 - Flags: approval-mozilla-aurora?
Attachment #8592210 - Flags: approval-mozilla-aurora+
Comment on attachment 8592210 [details] [diff] [review]
Patch

[Triage Comment]
Should be in 38 beta 8
Attachment #8592210 - Flags: approval-mozilla-beta+ → approval-mozilla-release+
Verified on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using Firefox 38 Beta 8 (buildID: 20150426174329) and the following in-content subdialogs aren't resizable: 
- Content tab -> "Advanced" (Fonts)
- Content tab -> "Colors"
- Privacy tab -> History -> Use custom settings for history -> "Settings for Clearing History"
- Security tab -> Passwords -> "Change Master Password" 

Additional exploratory testing related to in-content pref UI resizing is done under general testing for "In-Content Preferences" feature.
Flags: needinfo?(florin.mezei)
You need to log in before you can comment on or make changes to this bug.