1153403 - Don't allow dialogs to resize if they weren't resizable in the old preferences

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Alice0775 White]

Bug 1043612 has been landed.
However, the following in-content subdialogs do not remember its size.

* content > Fonts & Colors > Advanced...
* content > Languages > Choose...

Persistence of the size of the Fonts subdialog is useful for ja locale.
See Bug 1148923 [ja] Subdialog default width of in-content preferences is too narrow in ja locale

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Those dialogs don't have the persist attribute specified on the <window>, therefore they don't get persisted. We could look in to changing that though.

http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/fonts.xul
http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/languages.xul

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Looking at this more, these dialogs don't resize well and weren't designed to be resizable.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 4

[:Gijs (he/him)]

Comment on attachment 8592210 [details] [diff] [review]
Patch

Review of attachment 8592210 [details] [diff] [review]:
-----------------------------------------------------------------

Sold!

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/0e0d984f606c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0e0d984f606c

Comment 7

[:Gijs (he/him)]

Did we want to uplift this?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8592210 [details] [diff] [review]
Patch

Yeah, we should uplift this.

Approval Request Comment
[Feature/regressing bug #]: in-content preferences, shipping in v38
[User impact if declined]: some dialogs are resizable that weren't resizable before and they don't scale with the resizing
[Describe test coverage new/current, TreeHerder]: manual testing, been on m-c for over a week 
[Risks and why]: very low risk, just disables the resizing of only three dialogs
[String/UUID change made/needed]: none

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8592210 [details] [diff] [review]
Patch

I think this UI polish bug is safe and simple enough to take late in Beta. Beta+ Aurora+

ni Florin to add in-content pref UI resizing to his team's list for exploratory testing if time permits.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8592210 [details] [diff] [review]
Patch

[Triage Comment]
Should be in 38 beta 8

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e4a72e7cc9c1

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/e46c9612492a

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e46c9612492a

Comment 14

[Camelia Badau [:cbadau], Desktop QA]

Verified on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using Firefox 38 Beta 8 (buildID: 20150426174329) and the following in-content subdialogs aren't resizable: 
- Content tab -> "Advanced" (Fonts)
- Content tab -> "Colors"
- Privacy tab -> History -> Use custom settings for history -> "Settings for Clearing History"
- Security tab -> Passwords -> "Change Master Password" 

Additional exploratory testing related to in-content pref UI resizing is done under general testing for "In-Content Preferences" feature.