1153418 - remote and local video alignment during screen-sharing regressed, but not yet deployed to production.

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Screen Shot 2015-04-10 at 13.44.29.png

This is visible if you use the devtools "responsive design mode" at 800x660, while having your loop.server pref pointed at the dev server (https://loop-dev.stage.mozaws.net).  Which is to say that the regression hasn't yet been deployed to production, but presumably soon will be.

Using inspector to disable the "margin-left: 10px" rule added in the bug 1141128 makes the regression disappear.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

I suspect this doesn't want to block the latest deployment, but it does look sloppy.  This seems to be visible at most larger sizes I've tried.

Maybe we want to back out the 10px fix before deploying?

Comment 2

[Mark Banner (:standard8)]

Attachment: Fix an issue on Loop's standalone where the remote and video alignment during screenshare is 10px out.

I took a look and it turns out the issue was due to the fact we're trying to align the elements based on offsetLeft, but they have different parents. Post bug 1141128, one of the parents had a 10px margin, whereas the other didn't.

This patch effectively backs out bug 1141128 and applies the 10px margin to the standalone .media.nested item. This then takes care of the alignment properly as the parents all have the same left location.

Comment 3

[Mark Banner (:standard8)]

Attachment: Fix an issue on Loop's standalone where the remote and video alignment during screenshare is 10px out.

This includes an additional little fix that I think the "- 62.5px" taken out of the ".standalone .room-conversation-wrapper .room-inner-info-area" was trying to indirectly address. The fix here is to set the left point of the area to 0 on narrow screen widths, so the join button, camera prompt and other items still look good.

We could still probably improve on the layout, but I'm guessing that might be changing soon anyway.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8591625 [details] [diff] [review]
Fix an issue on Loop's standalone where the remote and video alignment during screenshare is 10px out.

Review of attachment 8591625 [details] [diff] [review]:
-----------------------------------------------------------------

Nicely done on both fixes; r=dmose!

Comment 5

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/76c6f37dafe7

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/76c6f37dafe7