1153446 - Unnecessary "double spacing" in nsserrors.properties

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[alex_mayorga]

¡Hola!

Over at http://mxr.mozilla.org/mozilla-central/source/security/manager/locales/en-US/chrome/pipnss/nsserrors.properties there are 29 cases of double spacing "  ".

This is a big no, no based on http://docs.translatehouse.org/projects/translate-toolkit/en/latest/commands/pofilter_tests.html#doublespacing

Could somebody please confirm if these double spaces are intentional?

¡Gracias!

Comment 1

[:Cykesiopka]

My guess is that these double spaces were just copied over from the hard coded en-US strings (e.g. SSLerrs.h):
  https://hg.mozilla.org/projects/nss/annotate/45cb71fd7bca/lib/ssl/SSLerrs.h#l8
  https://hg.mozilla.org/mozilla-central/annotate/102eaae71580/security/nss/lib/ssl/SSLerrs.h#l8

In any case, it doesn't look like these double spaces have any actual effect where they're used, so it should be safe to convert them to single spaces.

Comment 2

[:Cykesiopka]

Very minor, but it looks like there are actually only 28 cases - the search bar count functionality seems to be doing something weird...

Comment 3

[:Cykesiopka]

Attachment: bug1153446_nsserrors.properties-2spaces-to-1space_v1.patch

Comment 4

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 8600253 [details] [diff] [review]
bug1153446_nsserrors.properties-2spaces-to-1space_v1.patch

Review of attachment 8600253 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. We should also fix this in NSS itself (although who knows - maybe changing error strings isn't allowed due to compatibility constraints). Would you mind filing an NSS bug for that?

Comment 5

[:Cykesiopka]

(In reply to David Keeler [:keeler] (use needinfo?) from comment #4)
> LGTM. We should also fix this in NSS itself (although who knows - maybe
> changing error strings isn't allowed due to compatibility constraints).
> Would you mind filing an NSS bug for that?

Filed as Bug 1160721.

Comment 6

[:Cykesiopka]

Thanks for the review.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e2485ebc147

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/69703f8a1d40

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/69703f8a1d40

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/69703f8a1d40