Closed
Bug 1153446
Opened 9 years ago
Closed 9 years ago
Unnecessary "double spacing" in nsserrors.properties
Categories
(Core Graveyard :: Security: UI, defect)
Core Graveyard
Security: UI
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: alex_mayorga, Assigned: Cykesiopka)
References
Details
Attachments
(1 file)
13.54 KB,
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
¡Hola! Over at http://mxr.mozilla.org/mozilla-central/source/security/manager/locales/en-US/chrome/pipnss/nsserrors.properties there are 29 cases of double spacing " ". This is a big no, no based on http://docs.translatehouse.org/projects/translate-toolkit/en/latest/commands/pofilter_tests.html#doublespacing Could somebody please confirm if these double spaces are intentional? ¡Gracias!
Assignee | ||
Comment 1•9 years ago
|
||
My guess is that these double spaces were just copied over from the hard coded en-US strings (e.g. SSLerrs.h): https://hg.mozilla.org/projects/nss/annotate/45cb71fd7bca/lib/ssl/SSLerrs.h#l8 https://hg.mozilla.org/mozilla-central/annotate/102eaae71580/security/nss/lib/ssl/SSLerrs.h#l8 In any case, it doesn't look like these double spaces have any actual effect where they're used, so it should be safe to convert them to single spaces.
Component: General → Security: UI
OS: Windows 7 → All
Product: Firefox → Core
Hardware: x86 → All
Assignee | ||
Comment 2•9 years ago
|
||
Very minor, but it looks like there are actually only 28 cases - the search bar count functionality seems to be doing something weird...
Summary: 29 cases of "double spacing" at nsserrors.properties → Unnecessary "double spacing" in nsserrors.properties
Assignee | ||
Comment 3•9 years ago
|
||
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Attachment #8600253 -
Flags: review?(dkeeler)
Comment on attachment 8600253 [details] [diff] [review] bug1153446_nsserrors.properties-2spaces-to-1space_v1.patch Review of attachment 8600253 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. We should also fix this in NSS itself (although who knows - maybe changing error strings isn't allowed due to compatibility constraints). Would you mind filing an NSS bug for that?
Attachment #8600253 -
Flags: review?(dkeeler) → review+
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to David Keeler [:keeler] (use needinfo?) from comment #4) > LGTM. We should also fix this in NSS itself (although who knows - maybe > changing error strings isn't allowed due to compatibility constraints). > Would you mind filing an NSS bug for that? Filed as Bug 1160721.
Assignee | ||
Comment 6•9 years ago
|
||
Thanks for the review. https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e2485ebc147
Keywords: checkin-needed
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/69703f8a1d40
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•