Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Translation notification bar pushes Navbar/FindBar tool button when open Sidebar

RESOLVED FIXED in Firefox 40

Status

()

Firefox
Translation
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Alice0775 White, Assigned: Iaroslav Sheptykin)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 40
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

2 years ago
Created attachment 8591194 [details]
screenshot

Steps To Reproduce:
1. Enable Translation UI and restart
  user_pref("browser.translation.detectLanguage", true);
  user_pref("browser.translation.ui.show", true);
2. Open non English page
  e.g. http://www.mozilla.gr.jp/
  --- observe Translation notification bar should pop up.
3. Open Sidebar Ctrl+B

Actual Results:
  Translation notification bar pushes Navbar tool button.
  Hamburger button is also placed outside of browser window.
  Close button of Findbar is also placed outside of browser window.

Expected Results:
  Hamburger button and Close button of Findbar should be visible.
Blocks: 1008224
(Assignee)

Comment 1

2 years ago
Created attachment 8592820 [details] [diff] [review]
Clipping translation bar on small screens

Hi everybody!

With this patch the translationbar is clipped when the screen is too small for its contents. This is obviously not the best solution but it allows the toolbar to behave normally.

What do you think?
Attachment #8592820 - Flags: feedback?(florian)
(Assignee)

Comment 2

2 years ago
Created attachment 8592821 [details]
Screenshot-firefox-translation-clipped.png

After applying the patch translationbar behaves as this screenshot demonstrates.
Comment on attachment 8592820 [details] [diff] [review]
Clipping translation bar on small screens

Review of attachment 8592820 [details] [diff] [review]:
-----------------------------------------------------------------

We will still need to work on a better solution in bug 1008224, but this seems a very reasonable first step, thanks!

::: browser/themes/shared/translation/infobar.inc.css
@@ +25,5 @@
>      list-style-image: url(chrome://browser/skin/translating-16@2x.png);
>    }
>  }
>  
> +notification[value="translation"] hbox[anonid="details"]{

nit: missing space between ] and {
Attachment #8592820 - Flags: feedback?(florian) → feedback+
(Assignee)

Comment 4

2 years ago
Created attachment 8592918 [details] [diff] [review]
Clipping translation bar on small screens

Thanks for the feedback, Florian! I updated the patch. Does it suffice for fixing this bug? Or should I work on a more sophisticated solution and a test for this scenario? I would rather put effort into Bug 1008224.
Assignee: nobody → yarik.sheptykin
Attachment #8592820 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8592918 - Flags: review?(florian)
Comment on attachment 8592918 [details] [diff] [review]
Clipping translation bar on small screens

(In reply to Iaroslav Sheptykin from comment #4)

> Does it suffice for fixing this bug? Or should I work on a more
> sophisticated solution and a test for this scenario?

It's enough for here, thanks!

> I would rather put effort into Bug 1008224.

Thanks for looking into that one too! :-)
Attachment #8592918 - Flags: review?(florian) → review+
(Assignee)

Updated

2 years ago
Whiteboard: [checkin-needed]

Comment 6

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/4ce4e5679cb8
Whiteboard: [checkin-needed]
https://hg.mozilla.org/mozilla-central/rev/4ce4e5679cb8
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.