1153523 - Issue with image sprite on /firefox/hello/

Status: RESOLVED WORKSFORME

(www.mozilla.org :: Pages & Content, defect)

Description

[Alex Gibson [:agibson]]

Just got alerted that there are some display issues with the image sprite on the /firefox/hello/ product page, which was recently updated:

https://www.mozilla.org/en-US/firefox/hello/

I'm only on mobile and not able to check the cause of the problem currently, but it could be a caching issue perhaps. Not too sure atm.

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Hi, i created a pull request for this. Seems it's a background-size property problem. I'm new here so i hope i did it right.

https://github.com/mozilla/bedrock/pull/2907

Comment 2

[Alex Gibson [:agibson]]

Hi Nazim,

Thanks for the PR! I'm not able to test this change at the minute, have you done so locally? The background size of the image has recently changed, as we added another icon. 

Looking at stage & dev it appears ok to me. So this may be a caching issue that's affecting prod, but I'm not sure until I can take a proper look.

https://www-dev.allizom.org/en-US/firefox/hello/
https://www.allizom.org/en-US/firefox/hello/

Hopefully one of the other bedrock dev's can verify what the issue is soon.

Thanks

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Oh, yes you are right. At first I saw the sprite as 3480px x 240px. It must be cache, sorry about that. Now it is ok. I'm closing pull request.

Comment 4

[Alex Gibson [:agibson]]

Whatever the issue was seems to have corrected itself now, so marking as WORKSFORME