Closed Bug 1153551 Opened 5 years ago Closed 5 years ago

Priority button : description missing

Categories

(Thunderbird :: Message Compose Window, defect)

31 Branch
defect
Not set

Tracking

(thunderbird40 fixed)

RESOLVED FIXED
Thunderbird 40.0
Tracking Status
thunderbird40 --- fixed

People

(Reporter: 21Naown, Assigned: Paenglab)

Details

Attachments

(1 file)

Where : Custom buttons in the field with "Send, file attachment, ..."

For "Priority" button, its description flag is missing.

Look : https://lut.im/wCX2zpFy/HFLwRRFe
Patch adds a title and a tooltip.

Magnus, what do you think, should this be backported to TB 38? Then I could use no tooltiptext and use priorityMenu.label. With this the string freeze wouldn't be broken.
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8591260 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8591260 [details] [diff] [review]
priorityButton.patch

Review of attachment 8591260 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I don't think we need it for 38, it's just a minor UI glitch that's been there probably forever.
Attachment #8591260 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/4206a732aea5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
(In reply to Archaeopteryx [:aryx] from comment #3)
> https://hg.mozilla.org/comm-central/rev/4206a732aea5

A translation will be necessary ? I look only english words.
The translations are done later by the localizers, usually when the code gets migrated from comm-central to to comm-aurora.
Great, thank you for this answer !
You need to log in before you can comment on or make changes to this bug.