Closed Bug 1153630 Opened 5 years ago Closed 5 years ago

Height of background of button to Use Profile Icons from Gravatar doesn't autofit/grow if localized label/text gets linewrapped

Categories

(Hello (Loop) :: Client, defect, P3)

x86
Windows 8.1
defect
Points:
1

Tracking

(firefox38- verified, firefox38.0.5 fixed, firefox39 fixed, firefox40 fixed)

VERIFIED FIXED
mozilla40
Iteration:
40.2 - 27 Apr
Tracking Status
firefox38 - verified
firefox38.0.5 --- fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: aryx, Assigned: standard8)

Details

Attachments

(2 files)

Attached image screenshot of issue
The height of the background of the button to 'Use Profile Icons' from Gravatar doesn't grow if the localized label gets linewrapped due to its length. (Screenshot if from German translation in progress.

Here is a list of uploaded translations, you should be able to reproduce the issue with a longer translation.

[Tracking Requested - why for this release]: Feature lands with this release, hard to read text.
Not tracking as we won't block the release for that.
Mark, do you know who could help?
Flags: needinfo?(standard8)
I borrowed this from bug 1105708 as I knew we'd fixed something similar before (in just the conversation window it turns out). So a nice simple one-line fix. I can't see any adverse effects for this.
Attachment #8592796 - Flags: review?(dmose)
Assignee: nobody → standard8
Iteration: --- → 40.2 - 27 Apr
Points: --- → 1
Rank: 30
Flags: qe-verify+
Flags: needinfo?(standard8)
Flags: firefox-backlog+
Priority: -- → P3
Comment on attachment 8592796 [details] [diff] [review]
Allow buttons in the Loop panel to be bigger if required as L10n needs.

Review of attachment 8592796 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, and, happily it fixes several similar problems that were already visible in the UI showcase!

You may also be able to get rid of this line in panel.css as a result:

  height: auto; /* Needed to override .button's height:26px; */

r=dmose with or without that change
Attachment #8592796 - Flags: review?(dmose) → review+
https://hg.mozilla.org/integration/fx-team/rev/2fdb6d174440
Target Milestone: --- → mozilla40
https://hg.mozilla.org/mozilla-central/rev/2fdb6d174440
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Verified fixed with Firefox 40.a1 20150421.
Status: RESOLVED → VERIFIED
Comment on attachment 8592796 [details] [diff] [review]
Allow buttons in the Loop panel to be bigger if required as L10n needs.

Approval Request Comment
[Feature/regressing bug #]: New feature which landed in bug 1069962.
[User impact if declined]: In some localizations, the button to accept gravatar icon import will overflow the button height and be hard to read.
[Describe test coverage new/current, TreeHerder]: Verified fixed on Nightly.
[Risks and why]: Low, patch only changes CSS
[String/UUID change made/needed]: None
Attachment #8592796 - Flags: approval-mozilla-beta?
Attachment #8592796 - Flags: approval-mozilla-aurora?
Comment on attachment 8592796 [details] [diff] [review]
Allow buttons in the Loop panel to be bigger if required as L10n needs.

Safe and verified fix. Let's get this onto Beta and Aurora.
Attachment #8592796 - Flags: approval-mozilla-beta?
Attachment #8592796 - Flags: approval-mozilla-beta+
Attachment #8592796 - Flags: approval-mozilla-aurora?
Attachment #8592796 - Flags: approval-mozilla-aurora+
Comment on attachment 8592796 [details] [diff] [review]
Allow buttons in the Loop panel to be bigger if required as L10n needs.

[Triage Comment]
we merged m-b into m-r for 38
Attachment #8592796 - Flags: approval-mozilla-beta+ → approval-mozilla-release+
Reproduced with 38.0b6 nl build on a Windows 7 x64 machine. Verified as fixed with 38.0 build 2 (Build ID: 20150503173159): http://i.imgur.com/GiveHiy.png
Archaeopteryx, could you please provide the list of uploaded translations mentioned in comment 0 just to double check?
Flags: needinfo?(archaeopteryx)
Sorry for not including the list of translations in comment #0. You can find them at https://transvision.mozfr.org/string/?entity=browser/chrome/browser/loop/loop.properties:gravatars_promo_button_use&repo=beta and compare the string length to the German one (language code "de"). There are quite many locals which would have been affected.
Flags: needinfo?(archaeopteryx)
Verified on other Firefox 38.0 RC build 2 random builds with longer strings across platforms (Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 12.04 32-bit) : bn-IN, dsb, gd, kk, ro. The issues is fixed.
Removing qe-verify flag as verification on 38 Beta should suffice.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.