Closed Bug 1153634 Opened 5 years ago Closed 5 years ago

"ASSERTION: We can't be here unless newlines are hard breaks" with ruby, table, pre

Categories

(Core :: Layout, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: jruderman, Assigned: xidorn)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

Attached file testcase
###!!! ASSERTION: We can't be here unless newlines are hard breaks: 'preformatNewlines', file layout/generic/nsTextFrame.cpp, line 7597
Attached file stack
Attached patch patchSplinter Review
This assertion is broken (since bug 1143558) because with ruby and "white-space: pre", it is no longer true that if tabs are significant then newlines are also significant.

However, this condition in the assertion was equal to the one initializes the loop variable, which the latter was then changed in bug 411059. I see no reason why the assertion condition shouldn't be synced with the initializing condition. I even see no reason why it needs an assertion here at all, given that the initializing code is close to this assertion.
Attachment #8591476 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/d0d4d65f2daf
Assignee: nobody → quanxunzhen
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.