Closed Bug 1153651 Opened 5 years ago Closed 5 years ago

Define array.length as JSPROP_SHADOWABLE

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

Details

Attachments

(1 file)

Attached patch shadowableSplinter Review
Seems like sole purpose of JSPROP_SHADOWABLE is to make this work correctly.
Attachment #8591366 - Flags: review?(jorendorff)
Comment on attachment 8591366 [details] [diff] [review]
shadowable

Review of attachment 8591366 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, if this works, land it.

I really want all JSGetterOp/JSSetterOp properties to behave this way, so that the SHADOWABLE bit is unnecessary and can be removed. But that is for another day.
Attachment #8591366 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/90949b4f048d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.