Closed Bug 1153656 Opened 6 years ago Closed 6 years ago

semicolon-less-return.js is going to permafail when Gecko 40 merges to Aurora

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
major

Tracking

()

VERIFIED FIXED
mozilla40
Tracking Status
firefox40 --- verified

People

(Reporter: RyanVM, Assigned: arai)

References

Details

Attachments

(1 file, 1 obsolete file)

https://treeherder.mozilla.org/logviewer.html#?job_id=6441174&repo=try

21:54:21 INFO - /builds/slave/test/build/tests/jit-test/jit-test/tests/basic/semicolon-less-return.js:13:4 Error: Assertion failed: got "class is a reserved identifier", expected "unreachable expression after semicolon-less return statement":
21:54:21 INFO - /builds/slave/test/build/tests/jit-test/jit-test/tests/basic/semicolon-less-return.js:13:4 function f() {
21:54:21 INFO - /builds/slave/test/build/tests/jit-test/jit-test/tests/basic/semicolon-less-return.js:13:4 return
21:54:21 INFO - /builds/slave/test/build/tests/jit-test/jit-test/tests/basic/semicolon-less-return.js:13:4 class A { constructor() {} };
21:54:21 INFO - /builds/slave/test/build/tests/jit-test/jit-test/tests/basic/semicolon-less-return.js:13:4 }
21:54:21 INFO - /builds/slave/test/build/tests/jit-test/jit-test/tests/basic/semicolon-less-return.js:13:4
21:54:21 INFO - Exit code: 3
21:54:21 INFO - FAIL - basic/semicolon-less-return.js
21:54:21 WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/basic/semicolon-less-return.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/basic/semicolon-less-return.js:13:4 Error: Assertion failed: got "class is a reserved identifier", expected "unreachable expression after semicolon-less return statement": (code 3, args "")
Flags: needinfo?(arai.unmht)
Added classesEnabled function before testing TOK_CLASS.
Assignee: nobody → arai.unmht
Flags: needinfo?(arai.unmht)
Attachment #8591407 - Flags: review?(efaustbmo)
Comment on attachment 8591407 [details] [diff] [review]
Test class only if available in semicolon-less-return.js.

Review of attachment 8591407 [details] [diff] [review]:
-----------------------------------------------------------------

I think we should try to loadRelativeToScipt() tests/ecma_6/Class/shell.js so that we can have only one dynamic impl of classesEnabled(). Otherwise, this looks fine.
Attachment #8591407 - Flags: review?(efaustbmo) → review+
Thank you for reviewing :D

Is this change okay? or should directly load Class/shell.js from semicolon-less-return.js?
Attachment #8591407 - Attachment is obsolete: true
Attachment #8594243 - Flags: review?(efaustbmo)
Any news here? We're running low on time for this release cycle.
Flags: needinfo?(efaustbmo)
Comment on attachment 8594243 [details] [diff] [review]
Test class only if available in semicolon-less-return.js.

Review of attachment 8594243 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing that. r=me
Attachment #8594243 - Flags: review?(efaustbmo) → review+
https://hg.mozilla.org/mozilla-central/rev/614f18c77e1f
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Flags: needinfo?(efaustbmo)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.