Closed
Bug 1153658
Opened 9 years ago
Closed 9 years ago
browser_aboutperformance.js, browser_AddonWatcher.js, and browser_compartments.js are going to permafail when Gecko 40 merges to Aurora
Categories
(Toolkit :: Performance Monitoring, defect)
Toolkit
Performance Monitoring
Tracking
()
VERIFIED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | verified |
People
(Reporter: RyanVM, Assigned: Yoric)
References
Details
Attachments
(3 files)
+++ This bug was initially created as a clone of Bug #1153657 +++ WTH is with all the browser_compartments.js logspam, BTW? https://treeherder.mozilla.org/logviewer.html#?job_id=6440443&repo=try
Flags: needinfo?(dteller)
Reporter | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Thanks for spotting this. I'll fix this with bug 1153657. browser_compartments checks that the real-time performance data is updated correctly, is monotonic, etc. so it needs to check many things every few milliseconds. I suppose I could make the logs silent in case of success. Would this be useful?
Flags: needinfo?(dteller) → needinfo?(ryanvm)
Reporter | ||
Comment 3•9 years ago
|
||
Reducing 4MB of logspam sounds useful, yes.
Flags: needinfo?(ryanvm)
Assignee | ||
Comment 4•9 years ago
|
||
This patch will handle the logspam.
Keywords: checkin-needed
Whiteboard: [leave open]
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 5•9 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8333df669bf
Assignee: nobody → dteller
Assignee | ||
Updated•9 years ago
|
Attachment #8594703 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/e94753b73400
Keywords: checkin-needed
Whiteboard: [leave open] → [leave open][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e94753b73400
Whiteboard: [leave open][fixed-in-fx-team] → [leave open]
Reporter | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
Target Milestone: --- → mozilla40
Reporter | ||
Updated•9 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•