Closed Bug 1153665 Opened 5 years ago Closed 5 years ago

TaskDispatcher.h Werror bustage when Gecko 40 merges to Beta

Categories

(Core :: Audio/Video, defect, major)

defect
Not set
major

Tracking

()

VERIFIED FIXED
mozilla40
Tracking Status
firefox40 --- verified

People

(Reporter: RyanVM, Assigned: cpeterson)

References

Details

Attachments

(1 file)

https://treeherder.mozilla.org/logviewer.html#?job_id=6437856&repo=try

19:40:54 INFO - MediaEngineWebRTC.i_o
19:40:54 INFO - python2.7 /builds/slave/try-lx-00000000000000000000000/build/src/sccache/sccache.py /builds/slave/try-lx-00000000000000000000000/build/src/gcc/bin/g++ -m32 -march=pentiumpro -o MediaEngineWebRTC.i_o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/try-lx-00000000000000000000000/build/src/config/gcc_hidden.h -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DMOZ_GLUE_IN_PROGRAM -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/try-lx-00000000000000000000000/build/src/dom/media/webrtc -I. -I/builds/slave/try-lx-00000000000000000000000/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/slave/try-lx-00000000000000000000000/build/src/dom/base -I/builds/slave/try-lx-00000000000000000000000/build/src/dom/camera -I/builds/slave/try-lx-00000000000000000000000/build/src/media/libyuv/include -I/builds/slave/try-lx-00000000000000000000000/build/src/media/webrtc/signaling/src/common -I/builds/slave/try-lx-00000000000000000000000/build/src/media/webrtc/signaling/src/common/browser_logging -I/builds/slave/try-lx-00000000000000000000000/build/src/media/webrtc/trunk -I/builds/slave/try-lx-00000000000000000000000/build/src/ipc/chromium/src -I/builds/slave/try-lx-00000000000000000000000/build/src/ipc/glue -I../../../dist/include -I/builds/slave/try-lx-00000000000000000000000/build/src/obj-firefox/dist/include/nspr -I/builds/slave/try-lx-00000000000000000000000/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/MediaEngineWebRTC.i_o.pp -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Werror=endif-labels -Werror=int-to-pointer-cast -Werror=missing-braces -Werror=parentheses -Werror=pointer-arith -Werror=return-type -Werror=sequence-point -Werror=switch -Werror=trigraphs -Werror=type-limits -Werror=unused-label -Wno-invalid-offsetof -Wcast-align -Wno-error=uninitialized -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -DNDEBUG -DTRIMMED -g -fprofile-generate -O3 -fomit-frame-pointer -Werror -Wno-error=attributes /builds/slave/try-lx-00000000000000000000000/build/src/dom/media/webrtc/MediaEngineWebRTC.cpp
19:40:54 INFO - Unified_cpp_dom_media_webrtc0.i_o
19:40:58 INFO - In file included from ../../../dist/include/MediaPromise.h:13:0,
19:40:58 INFO - from ../../../dist/include/MediaTaskQueue.h:16,
19:40:58 INFO - from ../../../dist/include/MediaStreamGraph.h:19,
19:40:58 INFO - from /builds/slave/try-lx-00000000000000000000000/build/src/dom/media/webrtc/MediaEngine.h:11,
19:40:58 INFO - from /builds/slave/try-lx-00000000000000000000000/build/src/dom/media/webrtc/MediaEngineCameraVideoSource.h:8,
19:40:58 INFO - from /builds/slave/try-lx-00000000000000000000000/build/src/dom/media/webrtc/MediaEngineWebRTC.h:24,
19:40:58 INFO - from /builds/slave/try-lx-00000000000000000000000/build/src/dom/media/webrtc/MediaEngineWebRTC.cpp:22:
19:40:58 INFO - ../../../dist/include/TaskDispatcher.h: In destructor 'virtual mozilla::AutoTaskDispatcher::~AutoTaskDispatcher()':
19:40:58 INFO - ../../../dist/include/TaskDispatcher.h:68:12: error: unused variable 'assertDispatchSuccess' [-Werror=unused-variable]
Flags: needinfo?(bobbyholley)
assertDispatchSuccess should be moved inside #if defined(DEBUG) || !defined(RELEASE_BUILD) because it is only used in a MOZ_DIAGNOSTIC_ASSERT.
Assignee: nobody → cpeterson
Status: NEW → ASSIGNED
Attachment #8591395 - Flags: review?(bobbyholley)
Comment on attachment 8591395 [details] [diff] [review]
Wunused-variable_assertDispatchSuccess.patch

Review of attachment 8591395 [details] [diff] [review]:
-----------------------------------------------------------------

Instead of doing this, can you just put

unused << assertDispatchSuccess

along with the analogous line for rv near the bottom?

r=me with that change.
Attachment #8591395 - Flags: review?(bobbyholley) → review+
Flags: needinfo?(bobbyholley)
Thanks. I replaced the #if check with `unused << assertDispatchSuccess`:

https://hg.mozilla.org/integration/mozilla-inbound/rev/2622475e765b
https://hg.mozilla.org/mozilla-central/rev/2622475e765b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.