1153705 - [Stringray] [Smart-Home] Make icon for channels pinned to home

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

Description

[Sung Chiu[:sungchiu]]

1. Make an icon for channels pinned to home according to our UI spec.
2. Currently, TVManager has no APIs to get channel thumbnails, so default tv icon will be used.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] sean2449:Bug_1153705-pin-channel-icon > mozilla-b2g:master

Comment 2

[Sung Chiu[:sungchiu]]

Comment on attachment 8595178 [details] [review]
[gaia] sean2449:Bug_1153705-pin-channel-icon > mozilla-b2g:master

Change pinned TV channel icon to our UI spec https://docs.google.com/a/mozilla.com/file/d/0B2-G3kew1WpXNWh6UnJfbWc0dVU/edit. Note that there is no API to get channel thumbnail from provider in current implementation of TV API, so TV default font icon is used.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8595178 [details] [review]
[gaia] sean2449:Bug_1153705-pin-channel-icon > mozilla-b2g:master

Looks ok to me but I didn't test it on TV app, please make sure it works good on TV apps before landing.

Comment 4

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 5

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 6

[Sung Chiu[:sungchiu]]

Commit: https://github.com/mozilla-b2g/gaia/commit/b3bd3c03874090bfdbaae66455ca356bdcd37661
Gaia-Try(all green): https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=36334d5b1240a13609f51ece199358941c91a6a8