1153715 - [Settings] Fix the string consistency and string id of the add-on panel

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

- Replace all "addon" with "add-on".
- Remove "+" from the string id "+accessible-app-icon.ariaLabel".

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] crh0716:1153715 > mozilla-b2g:master

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8591467 [details] [review]
[gaia] crh0716:1153715 > mozilla-b2g:master

EJ, would you mind take a look at this simple patch? Thanks.

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8591467 [details] [review]
[gaia] crh0716:1153715 > mozilla-b2g:master

Thanks Arthur ! r++

Comment 4

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/ae4f5f39f6aa8c8ce88f7a6352edd5b28a619cf7

Comment 5

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame master and Aries KK master by the STR in comment 0.

Actual results: It shows "add-on" instead of "addon" and the string "add-on" is consistent on the add-ons panel.
See attachment: verified_Flame_master.png
Reproduce rate: 0/6


Device: Flame master_512mb (Pass)
Build ID               20151221150211
Gaia Revision          14aefb2519becfa32f31bcc3c9c995693421f19c
Gaia Date              2015-12-21 06:34:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8c9825377d0d8115e9fed64fd3700b1e54700dbe
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151221.182728
Firmware Date          Mon Dec 21 18:27:42 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Pass)
Build ID               20151221204910
Gaia Revision          14aefb2519becfa32f31bcc3c9c995693421f19c
Gaia Date              2015-12-21 06:34:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8c9825377d0d8115e9fed64fd3700b1e54700dbe
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151221.200242
Firmware Date          Mon Dec 21 20:02:51 UTC 2015
Bootloader             s1

Comment 6

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_master.png

Comment 7

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame master and Aries KK master.

STR：
1. Go to Settings -> "Add-ons" panel, check the "add-on".

Actual results: It shows "add-on" instead of "addon" and the string "add-on" is consistent on the add-ons panel.
See attachment: verified_Flame_master.png
Reproduce rate: 0/6


Device: Flame master_512mb (Pass)
Build ID               20151221150211
Gaia Revision          14aefb2519becfa32f31bcc3c9c995693421f19c
Gaia Date              2015-12-21 06:34:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8c9825377d0d8115e9fed64fd3700b1e54700dbe
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151221.182728
Firmware Date          Mon Dec 21 18:27:42 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Pass)
Build ID               20151221204910
Gaia Revision          14aefb2519becfa32f31bcc3c9c995693421f19c
Gaia Date              2015-12-21 06:34:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8c9825377d0d8115e9fed64fd3700b1e54700dbe
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151221.200242
Firmware Date          Mon Dec 21 20:02:51 UTC 2015
Bootloader             s1