Closed Bug 1153737 Opened 8 years ago Closed 8 years ago

Remove unnecessary uses of mozilla::pkix::ScopedPtr outside of mozilla::pkix

Categories

(Core :: Security: PSM, defect)

Product:
Core
Component:
Security: PSM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: briansmith, Assigned: briansmith)

References

Details

Attachments

(1 file)

less-ScopedPtr.patch
16.14 KB, patch
keeler
: review+
Details | Diff | Splinter Review 
      No description provided.
Comment on attachment 8591521 [details] [diff] [review]
less-ScopedPtr.patch

Review of attachment 8591521 [details] [diff] [review]:
-----------------------------------------------------------------

Great! r=me

::: security/apps/AppSignatureVerification.cpp
@@ +11,1 @@
>  #include "mozilla/RefPtr.h"

nit: if you feel like it, maybe put this #include in the right order as well?
Attachment #8591521 - Flags: review?(dkeeler) → review+
(In reply to David Keeler [:keeler] (use needinfo?) from comment #3)
> ::: security/apps/AppSignatureVerification.cpp
> @@ +11,1 @@
> >  #include "mozilla/RefPtr.h"
> 
> nit: if you feel like it, maybe put this #include in the right order as well?

I sorted all the includes in that file before pushing this:

https://hg.mozilla.org/integration/mozilla-inbound/rev/0511335a89fd

Thanks for the quick review turnaround!
Depends on: 1154188
https://hg.mozilla.org/mozilla-central/rev/0511335a89fd
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.