Remove unnecessary uses of mozilla::pkix::ScopedPtr outside of mozilla::pkix

RESOLVED FIXED in Firefox 40

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: briansmith, Assigned: briansmith)

Tracking

Trunk
mozilla40
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 8591521 [details] [diff] [review]
less-ScopedPtr.patch
Attachment #8591521 - Flags: review?(dkeeler)
Comment on attachment 8591521 [details] [diff] [review]
less-ScopedPtr.patch

Review of attachment 8591521 [details] [diff] [review]:
-----------------------------------------------------------------

Great! r=me

::: security/apps/AppSignatureVerification.cpp
@@ +11,1 @@
>  #include "mozilla/RefPtr.h"

nit: if you feel like it, maybe put this #include in the right order as well?
Attachment #8591521 - Flags: review?(dkeeler) → review+
(In reply to David Keeler [:keeler] (use needinfo?) from comment #3)
> ::: security/apps/AppSignatureVerification.cpp
> @@ +11,1 @@
> >  #include "mozilla/RefPtr.h"
> 
> nit: if you feel like it, maybe put this #include in the right order as well?

I sorted all the includes in that file before pushing this:

https://hg.mozilla.org/integration/mozilla-inbound/rev/0511335a89fd

Thanks for the quick review turnaround!

Updated

4 years ago
Depends on: 1154188
https://hg.mozilla.org/mozilla-central/rev/0511335a89fd
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.