1153737 - Remove unnecessary uses of mozilla::pkix::ScopedPtr outside of mozilla::pkix

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: less-ScopedPtr.patch

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=28418e11c5e7

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8591521 [details] [diff] [review]
less-ScopedPtr.patch

Review of attachment 8591521 [details] [diff] [review]:
-----------------------------------------------------------------

Great! r=me

::: security/apps/AppSignatureVerification.cpp
@@ +11,1 @@
>  #include "mozilla/RefPtr.h"

nit: if you feel like it, maybe put this #include in the right order as well?

Comment 4

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to David Keeler [:keeler] (use needinfo?) from comment #3)
> ::: security/apps/AppSignatureVerification.cpp
> @@ +11,1 @@
> >  #include "mozilla/RefPtr.h"
> 
> nit: if you feel like it, maybe put this #include in the right order as well?

I sorted all the includes in that file before pushing this:

https://hg.mozilla.org/integration/mozilla-inbound/rev/0511335a89fd

Thanks for the quick review turnaround!

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0511335a89fd