Closed Bug 1153738 Opened 8 years ago Closed 8 years ago

Make ScopedPtr a minimal proper subset of std::unique_ptr

Categories

(Core :: Security: PSM, defect)

Product:
Core
Component:
Security: PSM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: briansmith, Assigned: briansmith)

References

Details

Attachments

(1 file, 1 obsolete file)

better-ScopedPtr.patch [v2]
14.27 KB, patch
keeler
: review+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #1153737 +++

In particular:

* Define reset(T*) instead of operator=(T*), like unique_ptr.
* explicit operator bool.
* Remove features that aren't currently being used
Attached patch better-ScopedPtr.patch (obsolete) — — Splinter Review 

        Attachment #8591522 -
        Flags: review?(dkeeler)

    
    

    
  
Comment on attachment 8591621 [details] [diff] [review]
better-ScopedPtr.patch [v2]

Review of attachment 8591621 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

        Attachment #8591621 -
        Flags: review?(dkeeler) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/4fc4587d02bf
Status: ASSIGNED → RESOLVED
Closed: 8 years ago

          status-firefox40:
          affected → fixed
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.