Closed Bug 1153738 Opened 5 years ago Closed 5 years ago

Make ScopedPtr a minimal proper subset of std::unique_ptr

Categories

(Core :: Security: PSM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: briansmith, Assigned: briansmith)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1153737 +++

In particular:

* Define reset(T*) instead of operator=(T*), like unique_ptr.
* explicit operator bool.
* Remove features that aren't currently being used
Attached patch better-ScopedPtr.patch (obsolete) — Splinter Review
Attachment #8591522 - Flags: review?(dkeeler)
Comment on attachment 8591621 [details] [diff] [review]
better-ScopedPtr.patch [v2]

Review of attachment 8591621 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8591621 - Flags: review?(dkeeler) → review+
https://hg.mozilla.org/mozilla-central/rev/4fc4587d02bf
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.