Closed
Bug 1153738
Opened 9 years ago
Closed 9 years ago
Make ScopedPtr a minimal proper subset of std::unique_ptr
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: briansmith, Assigned: briansmith)
References
Details
Attachments
(1 file, 1 obsolete file)
14.27 KB,
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1153737 +++ In particular: * Define reset(T*) instead of operator=(T*), like unique_ptr. * explicit operator bool. * Remove features that aren't currently being used
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8591522 -
Flags: review?(dkeeler)
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=28418e11c5e7
Assignee | ||
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=89b4a3bc0163
Attachment #8591522 -
Attachment is obsolete: true
Attachment #8591522 -
Flags: review?(dkeeler)
Attachment #8591621 -
Flags: review?(dkeeler)
Comment on attachment 8591621 [details] [diff] [review] better-ScopedPtr.patch [v2] Review of attachment 8591621 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8591621 -
Flags: review?(dkeeler) → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4fc4587d02bf Thanks for the quick review turnaround.
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4fc4587d02bf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•