1153764 - "ASSERTION: float manager state should match saved state" with ruby

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: float manager state should match saved state: 'aState->mLineLeft == mLineLeft && aState->mBlockStart == mBlockStart && aState->mPushedLeftFloatPastBreak == mPushedLeftFloatPastBreak && aState->mPushedRightFloatPastBreak == mPushedRightFloatPastBreak && aState->mSplitLeftFloatAcrossBreak == mSplitLeftFloatAcrossBreak && aState->mSplitRightFloatAcrossBreak == mSplitRightFloatAcrossBreak && aState->mFloatInfoCount == mFloats.Length()', file layout/generic/nsFloatManager.h, line 300

(That's quite a conjunction for a single assertion!)

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

The explicit check of optional break opportunity removed in this patch doesn't interact well with float management code in block frame.

Actually, when a container frame which may contain float element triggers line
> *aLineReflowStatus = LINE_REFLOW_REDO_NEXT_BAND;
in nsBlockFrame::ReflowInlineFrame could cause this assertion.

After this patch, the line breaks originally handled here will be handled in standard way, via overflow backup and optional break opportunity in the ruby base.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c5af0320f177

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c5af0320f177