1153781 - [Calendar]The deleted events will be opened wrongly in notification.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P2)

Description

[SandKing]

Attachment: logcat002.txt

[1.Description]:
[Flame v2.2][Nexus5 v2.2&v3.0]We create an event form calendar and have a notification. If we delete the event, and then click the notification,we will enter a wrong page.
Occurence time:14:22
See attachments:logcat002.txt,VIDEO0516.mp4
[2.Testing Steps]: 
1.Open the calendar app.
2.Click the '+' button.
3.Add an event for a few minutes.
4.Click the 'save' button.
5.Delete the event.
6.Drag down the notification,and click the event.


[3.Expected Result]: 
6.We would see that the event have been delected.

[4.Actual Result]: 
6.We will enter a wrong page.

[5.Reproduction build]: 
Flame 2.2:[Affected]
Build ID               20150412002502
Gaia Revision          cec00d643f517ffd96cde559cd3bbd43ab85816c
Gaia Date              2015-04-10 21:41:12
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5005522fd68e
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150412.040730
Firmware Date          Sun Apr 12 04:07:41 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 2.2[Affected]
Build ID               20150412002502
Gaia Revision          cec00d643f517ffd96cde559cd3bbd43ab85816c
Gaia Date              2015-04-10 21:41:12
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5005522fd68e
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150412.045359
Firmware Date          Sun Apr 12 04:54:15 EDT 2015
Bootloader             HHZ12d

Device: Nexus 5 3.0[Affected]
Build ID               20150412160203
Gaia Revision          3c68964cb9fdba7cf0f6829b7f44562acaf1f1d7
Gaia Date              2015-04-10 14:38:19
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0a46652bd992
Gecko Version          40.0a1
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150412.193404
Firmware Date          Sun Apr 12 19:34:19 EDT 2015
Bootloader             HHZ12d
[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[SandKing]

Attachment: VIDEO0516.mp4

Comment 2

[Alissa（leave from Mozilla）]

This issue had been failed verified on Flame 3.0
Reproducing rate: 5/5
Device: Flame 3.0[Affected]
Build ID               20150412160203
Gaia Revision          3c68964cb9fdba7cf0f6829b7f44562acaf1f1d7
Gaia Date              2015-04-10 14:38:19
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0a46652bd992
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150412.192808
Firmware Date          Sun Apr 12 19:28:21 EDT 2015
Bootloader             L1TC000118D0

Comment 3

[Teri Wen [:twen]]

Bug is easily reproduced and high user impact, nominate for 3.0 work.

Comment 4

[Dylan Oliver [:doliver]]

The date format is read from the system l10n settings -- is the date format displaying differently in Calendar than it does in Clock/System/etc.?

Comment 5

[Dylan Oliver [:doliver]]

wrong bug, ignore comment #4

Comment 6

[Dylan Oliver [:doliver]]

triage: blocking 2.5, we should delete any associated notifications when deleting events.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] gaye:bug-1153781-revoke-notifications-for-deleted-events > mozilla-b2g:master

Comment 8

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31666

Sending review to jrburke since he's done notifications stuff with email (and since Miller's probably busy leaving Brazil).

Comment 9

[James Burke [:jrburke]]

Comment on attachment 8656351 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31666

I just have a question around the usage of title in revokeNotificationsForEvent, asked in the pull request, but the rest looks good. Flip review back once resolved, or ping me in IRC if I misunderstand, still new to some of the code.

Comment 10

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31666

Updated to use notification.data with an id instead of notification title following your suggestion!

Comment 11

[James Burke [:jrburke]]

Comment on attachment 8663769 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31666

r+ on code inspection and trying the code on device. The notification closed after deleting the event.

Comment 12

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/gaia/commit/c58673e372837d2037af952a0c95ccb98caeda05

Comment 13

[Gareth Aye [:gaye] (back from PTO)]

Thanks for the review James!

Comment 14

[SandKing]

This bug has been verified as pass on latest Flame v2.5,
STR:
Same STR as comment 0.

Actual result:
When user deleted the event, the notification will disappear.

Flame 2.5(pass):
Build ID               20150922150204
Gaia Revision          68361828ae88dffd04b250121b5f2472a63f4bf0
Gaia Date              2015-09-22 03:46:57
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a1ccea59e254a88f7bb44b0ad8a58b77b7eca339
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150922.183124
Firmware Date          Tue Sep 22 18:31:40 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0