Closed Bug 1153796 Opened 5 years ago Closed 5 years ago

Merge Bluetooth backend interfaces

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

defect
Not set

Tracking

(firefox40 fixed)

RESOLVED FIXED
2.2 S10 (17apr)
Tracking Status
firefox40 --- fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

(Depends on 1 open bug)

Details

Attachments

(5 files)

Bluetooth v1 and v2 slightly differ in their backend interfaces. We can unify both and share them between the two versions.
Comment on attachment 8591611 [details] [diff] [review]
[01] Bug 1153796: Unify variants of |BluetoothInterface::SspReply|

Review of attachment 8591611 [details] [diff] [review]:
-----------------------------------------------------------------

Steal review from Jocelyn. LGTM.
Attachment #8591611 - Flags: review?(joliu) → review+
Comment on attachment 8591612 [details] [diff] [review]
[02] Bug 1153796: Move dom/bluetooth/bluetooth2/BluetoothInterface.{cpp,h} to dom/bluetooth

LGTM.
Attachment #8591612 - Flags: review?(joliu) → review+
Comment on attachment 8591613 [details] [diff] [review]
[03] Bug 1153796: Share BluetoothInterface.{cpp,h} between Bluetooth v1 and v2

Review of attachment 8591613 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8591613 - Flags: review?(joliu) → review+
Comment on attachment 8591615 [details] [diff] [review]
[05] Bug 1153796: Update CLOBBER

Review of attachment 8591615 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8591615 - Flags: review?(joliu) → review+
Comment on attachment 8591614 [details] [diff] [review]
[04] Bug 1153796: Share BluetoothInterfaceHelpers.{cpp,h} between Bluetooth v1 and v2

Review of attachment 8591614 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8591614 - Flags: review?(joliu) → review+
Cool! Thanks Ben! I'll run the patch set on try before landing, because of my bad experience with bug 1152821.
Comment on attachment 8591615 [details] [diff] [review]
[05] Bug 1153796: Update CLOBBER

Found out that this patch is actually not needed.
Attachment #8591615 - Attachment is obsolete: true
Comment on attachment 8591615 [details] [diff] [review]
[05] Bug 1153796: Update CLOBBER

We actually do need this patch. Damn you, CLOBBER!
Attachment #8591615 - Attachment is obsolete: false
Depends on: 1154232
You need to log in before you can comment on or make changes to this bug.