Closed
Bug 1153796
Opened 5 years ago
Closed 5 years ago
Merge Bluetooth backend interfaces
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Firefox OS Graveyard
Bluetooth
Not set
Tracking
(firefox40 fixed)
RESOLVED
FIXED
2.2 S10 (17apr)
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
(Depends on 1 open bug)
Details
Attachments
(5 files)
|
15.82 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
621 bytes,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
37.57 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
23.05 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
638 bytes,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
Bluetooth v1 and v2 slightly differ in their backend interfaces. We can unify both and share them between the two versions.
|
Assignee | |
Comment 1•5 years ago
|
||
Attachment #8591611 -
Flags: review?(joliu)
|
|
Assignee | |
Comment 2•5 years ago
|
||
Attachment #8591612 -
Flags: review?(joliu)
|
|
Assignee | |
Comment 3•5 years ago
|
||
Attachment #8591613 -
Flags: review?(joliu)
|
|
Assignee | |
Comment 4•5 years ago
|
||
Attachment #8591614 -
Flags: review?(joliu)
|
|
Assignee | |
Comment 5•5 years ago
|
||
Attachment #8591615 -
Flags: review?(joliu)
|
||
Comment 6•5 years ago
|
||
Comment on attachment 8591611 [details] [diff] [review] [01] Bug 1153796: Unify variants of |BluetoothInterface::SspReply| Review of attachment 8591611 [details] [diff] [review]: ----------------------------------------------------------------- Steal review from Jocelyn. LGTM.
Attachment #8591611 -
Flags: review?(joliu) → review+
|
|
||
Comment 7•5 years ago
|
||
Comment on attachment 8591612 [details] [diff] [review] [02] Bug 1153796: Move dom/bluetooth/bluetooth2/BluetoothInterface.{cpp,h} to dom/bluetooth LGTM.
Attachment #8591612 -
Flags: review?(joliu) → review+
|
|
||
Comment 8•5 years ago
|
||
Comment on attachment 8591613 [details] [diff] [review] [03] Bug 1153796: Share BluetoothInterface.{cpp,h} between Bluetooth v1 and v2 Review of attachment 8591613 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8591613 -
Flags: review?(joliu) → review+
|
|
||
Comment 9•5 years ago
|
||
Comment on attachment 8591615 [details] [diff] [review] [05] Bug 1153796: Update CLOBBER Review of attachment 8591615 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8591615 -
Flags: review?(joliu) → review+
|
|
||
Comment 10•5 years ago
|
||
Comment on attachment 8591614 [details] [diff] [review] [04] Bug 1153796: Share BluetoothInterfaceHelpers.{cpp,h} between Bluetooth v1 and v2 Review of attachment 8591614 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8591614 -
Flags: review?(joliu) → review+
|
|
Assignee | |
Comment 11•5 years ago
|
||
Cool! Thanks Ben! I'll run the patch set on try before landing, because of my bad experience with bug 1152821.
|
|
Assignee | |
Comment 12•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d521602d8cf5
|
|
Assignee | |
Comment 13•5 years ago
|
||
The previous try didn't build on all platforms. https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3acd713b3f4
|
|
Assignee | |
Comment 14•5 years ago
|
||
Comment on attachment 8591615 [details] [diff] [review] [05] Bug 1153796: Update CLOBBER Found out that this patch is actually not needed.
Attachment #8591615 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 15•5 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/3a16edeb9ed2 https://hg.mozilla.org/integration/b2g-inbound/rev/0f94e1a00fcd https://hg.mozilla.org/integration/b2g-inbound/rev/a74d1c644c84 https://hg.mozilla.org/integration/b2g-inbound/rev/868ace3fafba https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=868ace3fafba
|
|
Assignee | |
Comment 16•5 years ago
|
||
Comment on attachment 8591615 [details] [diff] [review] [05] Bug 1153796: Update CLOBBER We actually do need this patch. Damn you, CLOBBER!
Attachment #8591615 -
Attachment is obsolete: false
|
||
Comment 17•5 years ago
|
||
sorry had to back this out for https://treeherder.mozilla.org/logviewer.html#?job_id=1724762&repo=b2g-inbound
|
|
Assignee | |
Comment 18•5 years ago
|
||
Once again with patch [05]. https://hg.mozilla.org/integration/b2g-inbound/rev/08499ede9432 https://hg.mozilla.org/integration/b2g-inbound/rev/e7ad039bd0f1 https://hg.mozilla.org/integration/b2g-inbound/rev/a1a5fece4e1d https://hg.mozilla.org/integration/b2g-inbound/rev/5eaa34942cad https://hg.mozilla.org/integration/b2g-inbound/rev/aa696047a779 https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=aa696047a779
|
||
Comment 19•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/08499ede9432 https://hg.mozilla.org/mozilla-central/rev/e7ad039bd0f1 https://hg.mozilla.org/mozilla-central/rev/a1a5fece4e1d https://hg.mozilla.org/mozilla-central/rev/5eaa34942cad https://hg.mozilla.org/mozilla-central/rev/aa696047a779
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S10 (17apr)
You need to log in
before you can comment on or make changes to this bug.
Description
•