Closed Bug 1153829 Opened 5 years ago Closed 5 years ago

Don't use MOZ_ALWAYS_INLINE for non-inline functions.

Categories

(Core :: Widget: Win32, defect)

x86_64
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(1 file)

Attached patch fixSplinter Review
This causes occasional (depending on how files are used in unified build) link problems on mingw, where we use -fno-keep-inline-dllexport.
Attachment #8591638 - Flags: review?(jmathies)
Comment on attachment 8591638 [details] [diff] [review]
fix

Seems fine, I don't think keyboard routines need to be heavily optimized.
Attachment #8591638 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/6334b8ddf5ae
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.