Closed Bug 1153834 Opened 5 years ago Closed 5 years ago

Remove long descriptions from job tooltips

Categories

(Tree Management :: Treeherder, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

The tooltips are not the most appropriate place for this - they belong either in help or in the job details panel. As is, we're adding thousands of additional strings to the DOM unnecessarily, bloating memory usage (if previous bugs filed against TBPL are anything to go by).
Attachment #8591661 - Flags: review?(cdawson)
This branch looks fine to me also in local testing.
Comment on attachment 8591661 [details] [review]
Move job description tooltips to job details panel

Looks great!  This should save us some memory.  :)
Attachment #8591661 - Flags: review?(cdawson) → review+
Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/2ab6626112dff979dd843ccdd111fd67408d3c8f
Bug 1153834 - Move job description tooltips to job details panel

Instead of displaying the long job description in the tooltip for every
job listed in the main jobs list, instead add it as the title text for
the job name in the job details panel. This avoids bloating the DOM with
thousands of longer strings.

We no longer check for the placeholder string "fill me", but I don't
think this matters, since we shouldn't be using that string in my
opinion anyway (vs leaving it blank) and to me it's more consistent to
always show a tooltip, rather than have the user wonder where it has
gone.
Thanks for the review! :-)
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ed42fc319e64b470dcb354717b60b16a65fba018
Bug 1153834 - Move job description tooltips to job details panel

Instead of displaying the long job description in the tooltip for every
job listed in the main jobs list, instead add it as the title text for
the job name in the job details panel. This avoids bloating the DOM with
thousands of longer strings.

We no longer check for the placeholder string "fill me", but I don't
think this matters, since we shouldn't be using that string in my
opinion anyway (vs leaving it blank) and to me it's more consistent to
always show a tooltip, rather than have the user wonder where it has
gone.
Depends on: 1229782
You need to log in before you can comment on or make changes to this bug.