Closed
Bug 1153872
Opened 10 years ago
Closed 10 years ago
CPOW abort in mozilla::dom::PBrowserChild::SendGetTabOffset(mozilla::gfx::IntPointTyped<mozilla::LayoutDevicePixel> *)
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla41
People
(Reporter: jimm, Assigned: gkrizsanits)
References
Details
(Keywords: regression)
Attachments
(1 file)
834 bytes,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
![]() |
Reporter | |
Updated•10 years ago
|
Keywords: regression
![]() |
Reporter | |
Comment 1•10 years ago
|
||
Bug 1092216 Child abort on send signature breakdown:
----------------------------------------------------
41 26.8% mozilla::dom::PBrowserChild::SendGetTabOffset(mozilla::gfx::IntPointTyped<mozilla::LayoutDevicePixel> *)
37 24.2% mozilla::dom::PStorageChild::SendPreload(nsCString const &,unsigned int const &,nsTArray<nsString> *,nsTArray<nsString> *,nsresult *)
34 22.2% mozilla::dom::PBrowserChild::SendIsParentWindowMainWidgetVisible(bool *)
![]() |
Reporter | |
Updated•10 years ago
|
tracking-e10s:
--- → m7+
Updated•10 years ago
|
Assignee: nobody → gkrizsanits
![]() |
Reporter | |
Comment 2•10 years ago
|
||
b76ec365-d2c9-4873-a4c9-6d7452150607
b3477221-d926-4efd-af85-0910f2150607
23563a24-5b91-42a4-a9e7-eb19d2150605
28f6e266-dbb3-4800-a36a-6e6ed2150605
0103d3de-6198-40f5-8735-ef64b2150607
30e46c5c-c3c7-4d6d-85c4-f20982150605
e4120a93-81fe-4861-be8a-6fb132150605
832cd1e7-921b-40cf-bebe-6fbff2150605
536f0351-7810-4c6f-8a2e-903ca2150605
979b1a83-359e-4d54-a244-8062d2150605
df773df4-ca87-4bf8-84df-f3b2e2150605
32df08f2-73df-4e34-abba-489f52150605
5ab41dca-2c37-4e57-9663-036742150605
Assignee | ||
Comment 3•10 years ago
|
||
This one is not truncated: https://crash-stats.mozilla.com/report/index/23563a24-5b91-42a4-a9e7-eb19d2150605
So from the plugin process we're trying to send a blocking message, but find an urgent message in the queue which we start to process. It's a CanvasRenderingContext2D::DrawWindow call via a CPOW. It was a bit weird to me at first that we start rendering suddenly while we wanted to send a sync message, but I guess this can just happen... Then we end up calling SendGetTabOffset (http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsPluginFrame.cpp#774) which is not high prio so we fail. I think the only thing we can do is to make GetTabOffset high prio too, but I don't know much about this area. Jim, what do you think? Does that sound reasonable to you?
Flags: needinfo?(jmathies)
![]() |
Reporter | |
Comment 4•10 years ago
|
||
(In reply to Gabor Krizsanits [:krizsa :gabor] from comment #3)
> This one is not truncated:
> https://crash-stats.mozilla.com/report/index/23563a24-5b91-42a4-a9e7-
> eb19d2150605
>
> So from the plugin process we're trying to send a blocking message, but find
> an urgent message in the queue which we start to process. It's a
> CanvasRenderingContext2D::DrawWindow call via a CPOW. It was a bit weird to
> me at first that we start rendering suddenly while we wanted to send a sync
> message, but I guess this can just happen... Then we end up calling
> SendGetTabOffset
> (http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsPluginFrame.
> cpp#774) which is not high prio so we fail. I think the only thing we can do
> is to make GetTabOffset high prio too, but I don't know much about this
> area. Jim, what do you think? Does that sound reasonable to you?
Yes that sounds like the right plan. Bill mentioned most of these involve tweaking prios on messages.
Flags: needinfo?(jmathies)
Assignee | ||
Comment 5•10 years ago
|
||
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8622426 -
Flags: review?(jmathies)
![]() |
Reporter | |
Updated•10 years ago
|
Attachment #8622426 -
Flags: review?(jmathies) → review+
Comment 8•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•