1153877 - Please make about:performance update every ten seconds instead of every two seconds

Status: VERIFIED FIXED

(Toolkit :: Performance Monitoring, defect)

Description

[Jason Spiro]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150411030207

Steps to reproduce:

I visited the about:performance special page.


Actual results:

I discovered that the displayed information updates every 2 seconds. But it is too hard for me to read so fast.


Expected results:

Please update the information less frequently.  I suspect that every 10 seconds might be fine, though I haven't experimented to see whether or not this would be an acceptable update interval.

Comment 1

[Jason Spiro]

If you'd like to fulfill this feature request, please see line 157 of
<chrome://global/content/aboutPerformance.js>.  You'd probably want to
change the number 2000 to some higher number.

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Indeed, to fix this bug, it is sufficient to change a single file:
 https://dxr.mozilla.org/mozilla-central/source/toolkit/components/aboutperformance/content/aboutPerformance.js?from=aboutPerformance.js#157

at the end of the file, replace `2000` with `10000`.

Comment 3

[Jason Spiro]

I have submitted patches to other projects before, but never to anything Mozilla-related.

Firefox is an established project, and so there's some established bureaucracy.  There's a learning curve involved in submitting patches to a project with established bureaucracy.  The Mozilla patch submission process, for example, includes more steps than the patch submission process for smaller projects.

Because I've been busy lately, it would be unwise for me to go through this learning curve at this time.

wrahman0, are you interested in submitting a patch?

Comment 4

[wrahman0]

Sure Jason, it looks like a very minor modification. I can submit a patch for it later today.

Comment 5

[wrahman0]

Attachment: bug1153877_increase_update_rate_to_ten_sec.diff

Increased the setInterval from 2 sec to 10 sec.

Side note:
I was wondering about the purpose of the setTimeout that wraps the setInterval. Shouldn't calling setInterval( ... , 10000 ) be sufficient to make the page update every 10 sec?

Comment 6

[David Teller [:Yoric] - still alive but not very active]

We display data on activity since the previous update. On startup, we immediately call `State.update()` to get initial data, then we wait a second before calling it again and displaying stuff. If we didn't wait one second, the calls to `State.update()` would be too close to each other, and our first dataset would be completely absurd.

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8592360 [details] [diff] [review]
bug1153877_increase_update_rate_to_ten_sec.diff

Review of attachment 8592360 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 8

[David Teller [:Yoric] - still alive but not very active]

Let's land this :)

Comment 9

[Carsten Book [:Tomcat]]

(In reply to David Rajchenbach-Teller [:Yoric] (use "needinfo") from comment #8)
> Let's land this :)

aye sir :)

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/75502e233121

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/75502e233121

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/75502e233121

Comment 13

[Jason Spiro]

Thank you all!  In the latest nightly, about:performance is now much more usable.

Comment 14

[wrahman0]

Sweet! I think you will like the play/pause feature even more!