Closed Bug 1153901 Opened 5 years ago Closed 5 years ago

Disable PlatformThread::SetName functions on builds with no SEH support.

Categories

(Core :: IPC, defect)

x86_64
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(1 file)

Attached patch fixSplinter Review
This avoids code duplication.

My original motivation to change the code was mingw, which doesn't support SEH exceptions. This means that under debugger, the exception is thrown, but never caught. We could #ifdef that code like we do in NSPR, but sharing implementation seems better.
Attachment #8591724 - Flags: review?(benjamin)
Attachment #8591724 - Flags: review?(benjamin) → review?(nfroyd)
Comment on attachment 8591724 [details] [diff] [review]
fix

Review of attachment 8591724 [details] [diff] [review]:
-----------------------------------------------------------------

I think it's slightly better to use an #ifdef here; implicitly creating a PRThread underneath IPC's code may not be a bad thing, but it doesn't seem like a good thing.  Replacing working code with NSPR calls is also not-so-great for long-term removal of NSPR usage.

I *do* realize those are pretty flimsy reasons...

r=me with #ifdef _MSC_VER
Attachment #8591724 - Flags: review?(nfroyd) → review+
I landed #ifdef version (we have HAVE_SEH_EXCEPTIONS, so I used that):

https://hg.mozilla.org/integration/mozilla-inbound/rev/6dbb7764db0e
https://hg.mozilla.org/mozilla-central/rev/6dbb7764db0e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.