Closed
Bug 1153901
Opened 10 years ago
Closed 10 years ago
Disable PlatformThread::SetName functions on builds with no SEH support.
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
2.11 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
This avoids code duplication.
My original motivation to change the code was mingw, which doesn't support SEH exceptions. This means that under debugger, the exception is thrown, but never caught. We could #ifdef that code like we do in NSPR, but sharing implementation seems better.
Attachment #8591724 -
Flags: review?(benjamin)
|
||
Updated•10 years ago
|
Attachment #8591724 -
Flags: review?(benjamin) → review?(nfroyd)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8591724 [details] [diff] [review]
fix
Review of attachment 8591724 [details] [diff] [review]:
-----------------------------------------------------------------
I think it's slightly better to use an #ifdef here; implicitly creating a PRThread underneath IPC's code may not be a bad thing, but it doesn't seem like a good thing. Replacing working code with NSPR calls is also not-so-great for long-term removal of NSPR usage.
I *do* realize those are pretty flimsy reasons...
r=me with #ifdef _MSC_VER
Attachment #8591724 -
Flags: review?(nfroyd) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
I landed #ifdef version (we have HAVE_SEH_EXCEPTIONS, so I used that):
https://hg.mozilla.org/integration/mozilla-inbound/rev/6dbb7764db0e
|
||
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•