Closed Bug 1153936 Opened 5 years ago Closed 5 years ago

nsIHttpChannelInteral attribute to opt out of alt-svc on per channel basis

Categories

(Core :: Networking: HTTP, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: mcmanus, Assigned: mcmanus)

Details

Attachments

(1 file)

It might be useful for a gecko component to opt out of Alt-Svc on a
per channel basis. Right now I don't see a need for this but maybe dev
tools or some diagnostic routine would want it available.
Comment on attachment 8591768 [details] [diff] [review]
nsIHttpChannelInteral attribute to opt out of alt-svc on per channel basis

Review of attachment 8591768 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not a fan of "let's add it Just In Case" patches (that's always a recipe for unused code sitting around), but since I probably would've r+'d this had it been in the original patch... sure, why not :)
Attachment #8591768 - Flags: review?(hurley) → review+
In general I agree - but channel granularity "no-feature" attributes have proved very helpful in circumstances where we need consistency for some reason.. be it no-cache, no-spdy, no-altsvc :)
https://hg.mozilla.org/mozilla-central/rev/e2dad85e1264
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.