1153936 - nsIHttpChannelInteral attribute to opt out of alt-svc on per channel basis

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Patrick McManus [:mcmanus]]

It might be useful for a gecko component to opt out of Alt-Svc on a
per channel basis. Right now I don't see a need for this but maybe dev
tools or some diagnostic routine would want it available.

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: nsIHttpChannelInteral attribute to opt out of alt-svc on per channel basis

Comment 2

[u408661]

Comment on attachment 8591768 [details] [diff] [review]
nsIHttpChannelInteral attribute to opt out of alt-svc on per channel basis

Review of attachment 8591768 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not a fan of "let's add it Just In Case" patches (that's always a recipe for unused code sitting around), but since I probably would've r+'d this had it been in the original patch... sure, why not :)

Comment 3

[Patrick McManus [:mcmanus]]

In general I agree - but channel granularity "no-feature" attributes have proved very helpful in circumstances where we need consistency for some reason.. be it no-cache, no-spdy, no-altsvc :)

Comment 4

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2dad85e1264

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e2dad85e1264