Closed Bug 1153937 Opened 9 years ago Closed 9 years ago

enable PushServiceLauncher

Categories

(Core :: DOM: Push Subscriptions, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1150683
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: dougt, Assigned: dougt)

References

Details

Attachments

(3 files)

Lets enable the push service launcher.  This startup component allows us to create the infra in order to run tests and to runtime change whether or not we support dom.push.
Attached patch 238782.diffSplinter Review
Attachment #8591770 - Flags: review?(nsm.nikhil)
Bug 1150683 subsumes `PushServiceLauncher` under `PushNotificationService`; this patch just updates the latter.
Attachment #8591881 - Flags: review?(nsm.nikhil)
Just the first patch.  The second patch requires other stuff to land.

https://hg.mozilla.org/integration/mozilla-inbound/rev/304f87a54059
https://hg.mozilla.org/mozilla-central/rev/304f87a54059
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Blocks: 1155253
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
try: -b o -p win32 -u none[Windows 7] -t xperf

For the perf io regression
Attachment #8593746 - Flags: review?(nsm.nikhil)
Improvement: Mozilla-Inbound-Non-PGO - Tp5 No Network Row Major MozAfterPaint (Non-Main Startup File IO Bytes) - WINNT 6.1 (ix) - 16.1% decrease
------------------------------------------------------------------------------------------------------------------------------------------------
   Previous: avg 898905.750 stddev 48030.632 of 12 runs up to revision 3f4103872afc
   New     : avg 754366.167 stddev 6849.277 of 12 runs since revision 5782e3653c5d
   Change  : -144539.583 (16.1% / z=3.009)
   Graph   : http://mzl.la/1EP2TJv

nsm -- this last patch improves startup io perf a bunch.
this really is going to be subsumed by 1150683.
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: