1154002 - [mozbuild] assert current_type is not None hit in read_mozconfig() on a recent b2g build

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Andrew Halberstadt [:ahal]]

STR:

cd $B2G_HOME
./repo sync
./mach help

Result:
This assertion is hit:
https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/mozconfig.py#363

This was regressed in the last couple of days, as I had been testing mochitest mach commands with emulator builds on Thursday. This means that all b2g mach commands are currently broken.

Gps, any idea if this is a bad assumption in read_mozconfig() or a bad mozconfig checked into B2G?

Comment 1

[Hiroyuki Ikezoe (:hiro)]

bug 1151787 seems to be related?

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: bug1154002

mach xpcshell-test works fine with this patch, mach help still fails yet.

Comment 3

[Andrew Halberstadt [:ahal]]

This is definitely regressed by bug 1151787. Still not sure if the bug lies with that patch, or with mozbuild.

A workaround is to revert that patch:
$ cd gonk-misc
$ git revert 09cc97f87175c3b89b0c347855b84a8cd2b767bb

Comment 4

[Andrew Halberstadt [:ahal]]

Your patch seems to fix it for me, even for |mach help|. What error are you seeing with help?

If you get it working would you mind pushing this as a pull request to gonk-misc and flag :mwu for review?

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix mach command breakage

Comment 6

[Hiroyuki Ikezoe (:hiro)]

(In reply to Andrew Halberstadt [:ahal] from comment #4)
> Your patch seems to fix it for me, even for |mach help|. What error are you
> seeing with help?

The error is:

TypeError: populate_context() takes exactly 1 argument (2 given)

  File "/home/ikezoe/B2G/gecko/python/mach/mach/main.py", line 344, in run
    return self._run(argv)
  File "/home/ikezoe/B2G/gecko/python/mach/mach/main.py", line 390, in _run
    args = parser.parse_args(argv)
  File "/usr/lib/python2.7/argparse.py", line 1690, in parse_args
    args, argv = self.parse_known_args(args, namespace)
  File "/usr/lib/python2.7/argparse.py", line 1722, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "/usr/lib/python2.7/argparse.py", line 1931, in _parse_known_args
    stop_index = consume_positionals(start_index)
  File "/usr/lib/python2.7/argparse.py", line 1887, in consume_positionals
    take_action(action, args)
  File "/usr/lib/python2.7/argparse.py", line 1796, in take_action
    action(self, namespace, argument_values, option_string)
  File "/home/ikezoe/B2G/gecko/python/mach/mach/dispatcher.py", line 101, in __call__
    self._handle_main_help(parser, namespace.verbose)
  File "/home/ikezoe/B2G/gecko/python/mach/mach/dispatcher.py", line 253, in _handle_main_help
    instance = handler.cls(self._context)
  File "/home/ikezoe/B2G/gecko/testing/mochitest/mach_commands.py", line 833, in __init__
    setattr(self, attr, getattr(context, attr, None))
  File "/home/ikezoe/B2G/gecko/python/mach/mach/main.py", line 160, in __getattribute__
    ret = object.__getattribute__(self, '_handler')(self, key)

There might be another issue on my environment.

Comment 7

[Michael Wu [:mwu]]

Comment on attachment 8592513 [details] [review]
Fix mach command breakage

Thanks!

Comment 8

[Kai-Zhen Li [:seinlin][:kli]]

https://github.com/mozilla-b2g/gonk-misc/commit/f2f2f0cbee2f2517070dd194051d509c07cdacff

Comment 9

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8592513 [details] [review]
Fix mach command breakage

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 1151787
User impact if declined:  b2g mach commands are currently broken on v2.2
Testing completed: verify on master
Risk to taking this patch (and alternatives if risky): low, just set a default value to variable
String or UUID changes made by this patch:none

Comment 10

[Kai-Zhen Li [:seinlin][:kli]]

v2.2: https://github.com/mozilla-b2g/gonk-misc/commit/122a178914f0b34f1c55fb1040f7fa5bcd11abc2