Enable child process memory reporting logging by default on B2G

RESOLVED FIXED in Firefox 40

Status

()

Toolkit
about:memory
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jld, Assigned: jld)

Tracking

unspecified
mozilla40
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
nsMemoryReporterManager.cpp has some compiled-out-by-default logging to stderr about the status of distributing memory report requests to child processes.  I think it should be enabled by default for B2G: multiprocess memory reporting is much more common/important there, and there's a general tendency towards more verbose logging on B2G.

Also, the logging should use printf_stderr(), which writes to the more useful Android logging service on B2G/Android (rather than only stderr, which is usually ignored there).

(This is already in my topic branch for bug 1151597 and friends, but it doesn't really belong in those bugs.)
(Assignee)

Comment 1

3 years ago
Created attachment 8597469 [details] [diff] [review]
bug1154041-memreplog-hg0.diff
Attachment #8597469 - Flags: review?(erahm)
Comment on attachment 8597469 [details] [diff] [review]
bug1154041-memreplog-hg0.diff

Review of attachment 8597469 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, this should be helpful for verifying memory reports are being properly triggered.
Attachment #8597469 - Flags: review?(erahm) → review+
https://hg.mozilla.org/mozilla-central/rev/bb344962d810
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.