Closed Bug 1154068 Opened 5 years ago Closed 5 years ago

rename relaxed to insecure scheme and add more runtime checks

Categories

(Core :: Networking: HTTP, defect)

Product:
Core
Component:
Networking: HTTP
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: mcmanus, Assigned: mcmanus)

Details

Attachments

(1 file)

rename relaxed to insecure scheme and add more runtime checks
10.85 KB, patch
u408661
: review+
Details | Diff | Splinter Review 
we used the term relaxed for http:// over tls; but someitmes we also
enforced the authentication if alt-svc changed the host involved. That
was all done correctly but the term relaxed wasn't very accurate in
those cases.

For clarity rename "relaxed" to be "insecureScheme". Also add a
runtime check (with debug assert) to paths to enforce that bit isn't
set where it shouldn't be (it isn't known to be).

This doesn't change any existing behavior
Attachment #8591938 - Flags: review?(hurley) → review+
https://hg.mozilla.org/mozilla-central/rev/e501f45919f1
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.