Clean up atomics code for old Visual Studio versions

RESOLVED FIXED in Firefox 40

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dmajor, Unassigned)

Tracking

unspecified
mozilla40
x86_64
Windows 8.1
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Nowadays we #define MOZ_HAVE_CXX11_ATOMICS whenever _MSC_VER is defined, so the non-CXX11 MSVC code should never be reached.
(Reporter)

Comment 1

4 years ago
Created attachment 8591986 [details] [diff] [review]
patch
Attachment #8591986 - Flags: review?(nfroyd)
Comment on attachment 8591986 [details] [diff] [review]
patch

Review of attachment 8591986 [details] [diff] [review]:
-----------------------------------------------------------------

Hooray for deleting all that code.
Attachment #8591986 - Flags: review?(nfroyd) → review+
(Reporter)

Comment 3

4 years ago
This probably didn't need a try run, but just to be safe: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4261da60b01c
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/94fd6fb15ee7
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.