Closed Bug 1154104 Opened 5 years ago Closed 5 years ago

Clean up atomics code for old Visual Studio versions

Categories

(Core :: MFBT, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: dmajor, Unassigned)

Details

Attachments

(1 file)

Nowadays we #define MOZ_HAVE_CXX11_ATOMICS whenever _MSC_VER is defined, so the non-CXX11 MSVC code should never be reached.
Attached patch patchSplinter Review
Attachment #8591986 - Flags: review?(nfroyd)
Comment on attachment 8591986 [details] [diff] [review]
patch

Review of attachment 8591986 [details] [diff] [review]:
-----------------------------------------------------------------

Hooray for deleting all that code.
Attachment #8591986 - Flags: review?(nfroyd) → review+
This probably didn't need a try run, but just to be safe: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4261da60b01c
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/94fd6fb15ee7
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.