Closed
Bug 1154104
Opened 9 years ago
Closed 9 years ago
Clean up atomics code for old Visual Studio versions
Categories
(Core :: MFBT, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: away, Unassigned)
Details
Attachments
(1 file)
|
11.82 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Nowadays we #define MOZ_HAVE_CXX11_ATOMICS whenever _MSC_VER is defined, so the non-CXX11 MSVC code should never be reached.
Attachment #8591986 -
Flags: review?(nfroyd)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8591986 [details] [diff] [review] patch Review of attachment 8591986 [details] [diff] [review]: ----------------------------------------------------------------- Hooray for deleting all that code.
Attachment #8591986 -
Flags: review?(nfroyd) → review+
This probably didn't need a try run, but just to be safe: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4261da60b01c
Keywords: checkin-needed
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/94fd6fb15ee7
Keywords: checkin-needed
|
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/94fd6fb15ee7
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•