1154127 - Bump gaia-toast

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Components, defect)

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Wilson, this is the output of |bower install gaia-components/gaia-toast --save|:

bower not-cached    git://github.com/gaia-components/gaia-toast.git#*
bower resolve       git://github.com/gaia-components/gaia-toast.git#*
bower checkout      gaia-toast#master
bower resolved      git://github.com/gaia-components/gaia-toast.git#fd000de635
bower cached        git://github.com/gaia-components/gaia-component.git#0.2.1
bower validate      0.2.1 against git://github.com/gaia-components/gaia-component.git#~0.2.0

Unable to find a suitable version for gaia-component, please choose one:
    1) gaia-component#~0.2.0 which resolved to 0.2.1 and is required by gaia-toast#fd000de635 
    2) gaia-component#~0.3.0 which resolved to 0.3.5 and is required by gaia-header#0.8.0Prefix the choice with ! to persist it to bower.json

? Answer:: 

and after choosing 2) the tree is left with

 M elements/gaia-toast/.bower.json
 M elements/gaia-toast/gaia-toast.js
?? elements/font-fit/
?? elements/gaia-component/README.md
?? elements/gaia-component/package.json

Should I also check-in font-fit? I am going to send you a minimal change for review first.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] timdream:gaia-toast-bump > mozilla-b2g:master

Comment 3

[Wilson Page [:wilsonpage]]

(In reply to Tim Guan-tin Chien [:timdream] (slow response; please ni? to queue) from comment #1)
> Wilson, this is the output of |bower install gaia-components/gaia-toast
> --save|:
> 
> bower not-cached    git://github.com/gaia-components/gaia-toast.git#*
> bower resolve       git://github.com/gaia-components/gaia-toast.git#*
> bower checkout      gaia-toast#master
> bower resolved     
> git://github.com/gaia-components/gaia-toast.git#fd000de635
> bower cached        git://github.com/gaia-components/gaia-component.git#0.2.1
> bower validate      0.2.1 against
> git://github.com/gaia-components/gaia-component.git#~0.2.0
> 
> Unable to find a suitable version for gaia-component, please choose one:
>     1) gaia-component#~0.2.0 which resolved to 0.2.1 and is required by
> gaia-toast#fd000de635 
>     2) gaia-component#~0.3.0 which resolved to 0.3.5 and is required by
> gaia-header#0.8.0Prefix the choice with ! to persist it to bower.json
> 
> ? Answer:: 
> 
> and after choosing 2) the tree is left with
> 
>  M elements/gaia-toast/.bower.json
>  M elements/gaia-toast/gaia-toast.js
> ?? elements/font-fit/
> ?? elements/gaia-component/README.md
> ?? elements/gaia-component/package.json
> 
> Should I also check-in font-fit? I am going to send you a minimal change for
> review first.

The reason font-fit keeps getting pulled in by Bower is because julien didn't check it in to the repo when he last updated gaia-header (probably same for gaia-component). Bower seems to do some other house-keeping when ever new dependencies are pulled-in/updated. These two packages aren't technically required because right now all the apps that use shared/ are using gaia-header/dist/gaia-header.js which has both fontfit.js and gaia-component.js bundled.

IMO I would just check in these deps now so that no-one else has this issue. It also gives people the freedom to use the unbundled dependencies should they wish to. For example, if you're using both gaia-header and gaia-toast, you wouldn't want two versions of gaia-component.js in your app, so you wouldn't use gaia-header/dist/gaia-header.js.

Let me know if any of that doesn't make sense :)

Comment 4

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/701af87dfc8e891d14855faf2cee30ed38a2ec46