Closed Bug 1154150 Opened 5 years ago Closed 5 years ago

don't create a FontFaceSet if we don't have any @font-face rules or FontFace objects

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
We create a FontFaceSet object for every document, regardless of whether @font-face rules were used in its style sheets or document.fonts is touched.  We should check whether the array of @font-face rules returned by the style set is non-empty before creating the FontFaceSet.
Attachment #8592066 - Flags: review?(jdaggett)
When a FontFace object is created from script, it calls aPresContext->Fonts() from its constructor, which causes the FontFaceSet to be created.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=54efcc453c6b (the red OS X builds are some transient problem)
Blocks: 1149381
Attachment #8592066 - Flags: review?(jdaggett) → review+
https://hg.mozilla.org/mozilla-central/rev/acfe0afcedee
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.