don't create a FontFaceSet if we don't have any @font-face rules or FontFace objects

RESOLVED FIXED in Firefox 40

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

Trunk
mozilla40
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8592066 [details] [diff] [review]
patch

We create a FontFaceSet object for every document, regardless of whether @font-face rules were used in its style sheets or document.fonts is touched.  We should check whether the array of @font-face rules returned by the style set is non-empty before creating the FontFaceSet.
Attachment #8592066 - Flags: review?(jdaggett)
(Assignee)

Comment 1

3 years ago
When a FontFace object is created from script, it calls aPresContext->Fonts() from its constructor, which causes the FontFaceSet to be created.
(Assignee)

Comment 2

3 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=54efcc453c6b (the red OS X builds are some transient problem)
(Assignee)

Updated

3 years ago
Blocks: 1149381

Updated

3 years ago
Attachment #8592066 - Flags: review?(jdaggett) → review+
https://hg.mozilla.org/mozilla-central/rev/acfe0afcedee
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.