Can't comment deleted files

NEW
Unassigned

Status

4 years ago
3 years ago

People

(Reporter: glandium, Unassigned)

Tracking

Details

(Whiteboard: [to be fixed in core])

(Reporter)

Description

4 years ago
Sometimes, something has to be said about a file being removed, and there's currently no way to do that.

Comment 1

4 years ago
:smacleod, is this going to be fixed with your upstream reviewboard work to improve diffs?
Flags: needinfo?(smacleod)
(In reply to Dan Minor [:dminor] from comment #1)
> :smacleod, is this going to be fixed with your upstream reviewboard work to
> improve diffs?

Sort of - I'm going to be adding the ability to toggle showing the contents of deleted files - so you could comment on the old deleted code. Actually just commenting on the entire deleted file won't be enabled by my work though.

That is definitely something core should get though. Until then a general comment in the top or bottom of the review will have to do.
Flags: needinfo?(smacleod)
Whiteboard: [to be fixed in core]
(Assignee)

Updated

3 years ago
Product: Developer Services → MozReview

Comment 3

3 years ago
To build on comment 2, it sounds like this is *not* fixed in the upstream work referenced in bug 1114997; looks like that merely lets you see the content of a deleted file.
Component: General → Review Board: Upstream
(In reply to Mark Côté [:mcote] from comment #3)
> To build on comment 2, it sounds like this is *not* fixed in the upstream
> work referenced in bug 1114997; looks like that merely lets you see the
> content of a deleted file.

are you sure about that? if you can see the deleted file you *should* be able to comment on it...

Comment 5

3 years ago
Nope, not sure, which is why I said "sounds like". :)  The commit message says 'This change will make it possible to view deleted file content by providing a clickable link that is labelled "Show content."', and the "Testing Done" section says only that "deleted files could be correctly displayed on Chrome and Firefox without triggering a full page reload".  So it sounded like they kind of jury-rigged this in.  But I don't know for sure.
You need to log in before you can comment on or make changes to this bug.