1154170 - [Messages] Can't insert an attachment at a specific place

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

Description

[Julien Wajsberg [:julienw]]

From Bug 1154156 comment 3:

BTW, the following if() statement seems that could not be executed, because when I click textbox, the document.activeElement is dom.message, then I click attachment button to add attachment, the document.activeElement will become attachment button, so I can't insert image to where I want.

if (document.activeElement === dom.message) {
          // insert element at caret position
          var range = window.getSelection().getRangeAt(0);
          var firstNodes = fragment.firstChild;
          range.deleteContents();
          range.insertNode(fragment);
          this.scrollToTarget(range);
          dom.message.focus();
          range.setStartAfter(firstNodes);
        }


STR:
1. open Messages app.
2. open the 'New Message' panel.
3. enter several lines of text.
4. tap in the middle of the text.
5. tap the "pick attachment" icon, then select any image, then accept.
6. wait until the SMS application is displayed again.

Expected:
* The attachment has been added in cursor location.

Actual:
* It's been added at the end of the message.

QAWanted for branch checks.

Comment 1

[Pi Wei Cheng [:piwei] (inactive)]

This issue reproduces on all branches on Flame, including on v18D-1 base only. Attachment is added to the end of message instead of location of cursor.

Another issue I encountered on v3.0 and on v2.1 is, with Keyboard enabled it is almost impossible to hit the paperclip icon. I'll look into bugging this separately.

Device: Flame 3.0 Master (full flashed 319MB KK)
BuildID: 20150414072436
Gaia: c8cb0c0ebb8dd1f5c0c9037e38f8e4b237beb77b
Gecko: 388f5861dc7d
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Device: Flame 2.2 (full flashed 319MB KK)
BuildID: 20150414002504
Gaia: 73645b097720f3ca594a14d288b87d3885d7fc9d
Gecko: 85ea1be9ac7d
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 2.1 (full flashed 319MB KK)
BuildID: 20150414001210
Gaia: bbe983b4e8bebfec26b3726b79568a22d667223c
Gecko: 3e3cbe35bce3
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.0 (full flashed 319MB KK)
BuildID: 20150414000204
Gaia: 84898cadf28b1a1fcd03b726cff658de470282f0
Gecko: de92ad41847a
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 32.0 (2.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Julien Wajsberg [:julienw]]

Wow, did this ever work ? :)

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage:
non-regression. let's put into backlog.

Comment 4

[Oleg Zasypkin [:azasypkin]]

(In reply to Julien Wajsberg [:julienw] (PTO April 6th) from comment #2)
> Wow, did this ever work ? :)

My v1.3/v1.4 Hamachi says it doesn't work since v1.3 at least :)

Comment 6

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 7

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(