Closed Bug 1154184 Opened 6 years ago Closed 6 years ago

[trunk] Commits for bug 1151607 breaks build process when using --disable-tests

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(firefox40 fixed)

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: fredbezies, Assigned: jld)

References

Details

Attachments

(2 files, 1 obsolete file)

I tried this morning to build Mozilla Thunderbird (from trunk code), and it stopped really quick.

Fatal error was found here :

"/home/fred/logs/mail/src/mozilla/security/sandbox/linux/gtest/TestSandboxUtil.cpp:7:25: fatal error: gtest/gtest.h: No such file or directory
 #include "gtest/gtest.h"
                         ^
compilation terminated."

Using lxr.mozilla.org, I found its last modification was made by bug 1151607.

I did not try reverting it. I'm trying to see if it also breaks mozilla firefox trunk building process.
It also breaks Mozilla Firefox trunk build process. Or is it related to gcc 4.9 ?
Product: Thunderbird → Core
Summary: Commits for bug 1151607 breaks mozilla thunderbird build process → [trunk] Commits for bug 1151607 breaks both mozilla thunderbird and mozilla firefox build process
Target Milestone: --- → mozilla40
I noticed a "workaround" : I have to comment --disable-tests in my .mozconfig to get mozilla firefox build.
Summary: [trunk] Commits for bug 1151607 breaks both mozilla thunderbird and mozilla firefox build process → [trunk] Commits for bug 1151607 breaks build process when using --disable-tests
Duplicate of this bug: 1154574
FTR, this breaks xulrunner on Linux too, and that's used by binary addons so this should be fixed before we get 40 to Beta, preferably much before then.
I broke it, so I'll fix it (unless somebody else already has a patch).
Assignee: nobody → jld
Attached patch bug1154184-test-dir-hg0.diff (obsolete) — Splinter Review
Tested by building Firefox with --disable-tests, which reproduces the failure in comment #0 without this patch.
Attachment #8592951 - Flags: review?(mh+mozilla)
(In reply to Jed Davis [:jld] {UTC-7} from comment #6)
> Created attachment 8592951 [details] [diff] [review]
> bug1154184-test-dir-hg0.diff
> 
> Tested by building Firefox with --disable-tests, which reproduces the
> failure in comment #0 without this patch.

better with TEST_DIRS I think?
Flags: needinfo?(jld)
(In reply to Alex Xu from comment #7)
> better with TEST_DIRS I think?

Thanks for pointing that out.
Flags: needinfo?(jld)
Attachment #8592951 - Attachment is obsolete: true
Attachment #8592951 - Flags: review?(mh+mozilla)
Attachment #8594960 - Flags: review?(gps)
Attachment #8594960 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/288280490661
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.