Closed Bug 1154206 Opened 5 years ago Closed 2 years ago

Intermittent test_bug785324.html | test left refresh driver under test control - expected PASS

Categories

(Core :: Layout, defect, P3)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox58 --- fixed
firefox59 --- fixed

People

(Reporter: cbook, Assigned: kats)

References

()

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Rev5 MacOSX Yosemite 10.10 fx-team opt test mochitest-5

https://treeherder.mozilla.org/logviewer.html#?job_id=2671246&repo=fx-team

01:48:41 INFO - 357 INFO TEST-UNEXPECTED-FAIL | layout/generic/test/test_bug785324.html | test left refresh driver under test control - expected PASS
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
This is actually a problem in test_bug784410, where it ends up calling AdvanceTimeAndRefresh again after calling RestoreNormalRefresh(). Log snippet from [1]:

TEST-START | layout/generic/test/test_bug784410.html
GECKO(2410) | RestoreNormalRefresh on 0x7f72f63c7000
GECKO(2410) | AdvanceTimeAndRefresh on 0x7f72f63c7000
GECKO(2410) | AdvanceTimeAndRefresh on 0x7f72f63c7000
GECKO(2410) | AdvanceTimeAndRefresh on 0x7f72f63c7000
TEST-OK | layout/generic/test/test_bug784410.html | took 1072ms
GECKO(2410) | AdvanceTimeAndRefresh on 0x7f72f63c7000
TEST-START | layout/generic/test/test_bug831780.html
TEST-INFO | started process screentopng
TEST-INFO | screentopng: exit 0
Buffered messages logged at 22:54:39
TEST-PASS | layout/generic/test/test_bug831780.html | scrollWidth should be 1
TEST-PASS | layout/generic/test/test_bug831780.html | scrollHeight should be 1
Buffered messages finished
TEST-UNEXPECTED-FAIL | layout/generic/test/test_bug831780.html | test left refresh driver under test control
    afterCleanup@SimpleTest/SimpleTest.js:1162:13
    executeCleanupFunction@SimpleTest/SimpleTest.js:1211:13
    SimpleTest.finish@SimpleTest/SimpleTest.js:1230:5
    @SimpleTest/SimpleTest.js:1436:13
    rval@SimpleTest/SimpleTest.js:146:17
    EventHandlerNonNull*this.addLoadEvent@SimpleTest/SimpleTest.js:171:13
    @SimpleTest/SimpleTest.js:1434:5

This failure happens more frequently with webrender enabled, and I need to fix it in order to turn on mochitests for linux64-qr.

[1] https://treeherder.mozilla.org/logviewer.html#?job_id=151540036&repo=try&lineNumber=11190
Assignee: nobody → bugmail
Blocks: 1334189
Comment on attachment 8936792 [details]
Bug 1154206 - Don't end the test until all the advanceTimeAndRefresh calls are done.

https://reviewboard.mozilla.org/r/207500/#review213936
Attachment #8936792 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dba2aba69348
Don't end the test until all the advanceTimeAndRefresh calls are done. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/dba2aba69348
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.