Closed
Bug 1154223
Opened 7 years ago
Closed 7 years ago
[Settings] Remove the support for pressing the escape key
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: arthurcc, Assigned: arthurcc)
Details
Attachments
(1 file)
The code[1] seems out of dated and we don't have complete spec for handling the key event now. Remove the code for the time being. [1]: https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/settings.js#L110
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Comment on attachment 8592157 [details] [review] [gaia] crh0716:1154223 > mozilla-b2g:master EJ, would you mind review this simple patch? Thanks.
Attachment #8592157 -
Flags: review?(ejchen)
Comment on attachment 8592157 [details] [review] [gaia] crh0716:1154223 > mozilla-b2g:master As you said, it seems that we have no clear documentation / spec for this "feature", because the code only works on desktop client and user can directly click the buttons to do the same thing, so maybe we can really drop this feature. r+ and see what's going on later. Thanks Arthur.
Attachment #8592157 -
Flags: review?(ejchen) → review+
Updated•7 years ago
|
Keywords: checkin-needed
Comment 5•7 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/5fdd44defc31ff93b2b0bc932565410856e063ff
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•