Closed Bug 1154223 Opened 6 years ago Closed 6 years ago

[Settings] Remove the support for pressing the escape key

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: arthurcc, Assigned: arthurcc)

Details

Attachments

(1 file)

[gaia] crh0716:1154223 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
eragonj
: review+
Details | Review 
The code[1] seems out of dated and we don't have complete spec for handling the key event now. Remove the code for the time being.

[1]: https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/settings.js#L110
Comment on attachment 8592157 [details] [review]
[gaia] crh0716:1154223 > mozilla-b2g:master

EJ, would you mind review this simple patch? Thanks.
Attachment #8592157 - Flags: review?(ejchen)
Comment on attachment 8592157 [details] [review]
[gaia] crh0716:1154223 > mozilla-b2g:master

As you said, it seems that we have no clear documentation / spec for this "feature", because the code only works on desktop client and user can directly click the buttons to do the same thing, so maybe we can really drop this feature.

r+ and see what's going on later.

Thanks Arthur.
Attachment #8592157 - Flags: review?(ejchen) → review+
Thanks, EJ.
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.