1154233 - Merge private browsing indicator rules from browser-aero.css into browser.css

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[:Gijs (he/him)]

Comment on attachment 8592167 [details] [diff] [review]
patch

Review of attachment 8592167 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: browser/themes/windows/browser-aero.css
@@ +344,5 @@
>  #minimize-button:-moz-locale-dir(rtl),
>  #restore-button:-moz-locale-dir(rtl),
>  #close-button:-moz-locale-dir(rtl) {
>    transform: scaleX(-1);
>  }

I realize this isn't related to your patch, but it seems odd that these rules are specific to aero. :-\

Comment 2

[Dão Gottwald [:dao]]

(In reply to :Gijs Kruitbosch from comment #1)
> ::: browser/themes/windows/browser-aero.css
> @@ +344,5 @@
> >  #minimize-button:-moz-locale-dir(rtl),
> >  #restore-button:-moz-locale-dir(rtl),
> >  #close-button:-moz-locale-dir(rtl) {
> >    transform: scaleX(-1);
> >  }
> 
> I realize this isn't related to your patch, but it seems odd that these
> rules are specific to aero. :-\

The images used on XP don't need that, but windowControls.png does.

Comment 3

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/3c249cba737c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3c249cba737c