Closed Bug 1154233 Opened 5 years ago Closed 5 years ago

Merge private browsing indicator rules from browser-aero.css into browser.css

Categories

(Firefox :: Theme, defect)

All
Windows
defect
Not set
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 40
Iteration:
40.2 - 27 Apr
Tracking Status
firefox40 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #8592167 - Flags: review?(gijskruitbosch+bugs)
Flags: qe-verify-
Flags: firefox-backlog+
Comment on attachment 8592167 [details] [diff] [review]
patch

Review of attachment 8592167 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: browser/themes/windows/browser-aero.css
@@ +344,5 @@
>  #minimize-button:-moz-locale-dir(rtl),
>  #restore-button:-moz-locale-dir(rtl),
>  #close-button:-moz-locale-dir(rtl) {
>    transform: scaleX(-1);
>  }

I realize this isn't related to your patch, but it seems odd that these rules are specific to aero. :-\
Attachment #8592167 - Flags: review?(gijskruitbosch+bugs) → review+
(In reply to :Gijs Kruitbosch from comment #1)
> ::: browser/themes/windows/browser-aero.css
> @@ +344,5 @@
> >  #minimize-button:-moz-locale-dir(rtl),
> >  #restore-button:-moz-locale-dir(rtl),
> >  #close-button:-moz-locale-dir(rtl) {
> >    transform: scaleX(-1);
> >  }
> 
> I realize this isn't related to your patch, but it seems odd that these
> rules are specific to aero. :-\

The images used on XP don't need that, but windowControls.png does.
https://hg.mozilla.org/mozilla-central/rev/3c249cba737c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
You need to log in before you can comment on or make changes to this bug.