Closed Bug 1154468 Opened 6 years ago Closed 6 years ago

unused function getServerIdAndPageIdFromTree in am-identity-edit.xul

Categories

(MailNews Core :: Account Manager, enhancement)

enhancement
Not set
normal

Tracking

(firefox40 affected)

RESOLVED FIXED
Thunderbird 40.0
Tracking Status
firefox40 --- affected

People

(Reporter: aceman, Assigned: aceman)

Details

Attachments

(1 file)

1.22 KB, patch
iann_bugzilla
: review+
mkmelin
: review+
Details | Diff | Splinter Review
There seems to be an unused function getServerIdAndPageIdFromTree() in /mailnews/base/prefs/content/am-identity-edit.xul:

  <script type="application/javascript">
  <![CDATA[
    function getServerIdAndPageIdFromTree(tree)
    {
      return {"serverId": gAccount.incomingServer.key, "pageId": "" }
    }
  ]]>
  </script>

http://mxr.mozilla.org/comm-central/search?string=getServerIdAndPageIdFromTree&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
Attached patch patchSplinter Review
I see no usage of it in c-c. There seem to have been some usage of a function called like this in the file AccountManager.js in hg revision 285:
AccountManager.js:  var result = getServerIdAndPageIdFromTree(accounttree);
AccountManager.js:  var result = getServerIdAndPageIdFromTree(accounttree);
AccountManager.js:  var result = getServerIdAndPageIdFromTree(accounttree);
AccountManager.js:  var currentSelection = getServerIdAndPageIdFromTree(tree);
AccountManager.js:  var result = getServerIdAndPageIdFromTree(accounttree);
AccountManager.js:function getServerIdAndPageIdFromTree(tree)
am-help.js:  var idStruct = getServerIdAndPageIdFromTree(accounttree);
am-identity-edit.xul:    function getServerIdAndPageIdFromTree(tree)

But I don't see that exactly this function in am-identity-edit.xul was called from anywhere, as the AccountManager.js defined its own version of it.
Attachment #8592493 - Flags: review?(mkmelin+mozilla)
Attachment #8592493 - Flags: review?(iann_bugzilla)
Attachment #8592493 - Flags: review?(iann_bugzilla) → review+
Attachment #8592493 - Flags: review?(mkmelin+mozilla) → review+
Thanks.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/8d15ac32e757
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
You need to log in before you can comment on or make changes to this bug.