Closed
Bug 1154470
Opened 10 years ago
Closed 10 years ago
Refactor Artifact handling out of ``Jobs.py``
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: camd, Assigned: camd)
Details
Attachments
(1 file)
``models/jobs.py`` has gotten huge, and we should refactor as much as possible out of it to make it more manageable.
Artifacts are one area that can be pretty easily refactored out of it into its own model.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
Adding you guys as CC'd. I thought we could chat about going forward with refactoring ``jobs.py`` in general. This is my first "salvo" in that regard. We don't have to do it all at once. But as we touch areas related to it, perhaps we could do it as we go.
Assignee | ||
Comment 2•10 years ago
|
||
I was hoping we could chat about refactoring a bit in tomorrow's meeting. Here's my first proposal.
Attachment #8592919 -
Flags: review?(mdoglio)
Attachment #8592919 -
Flags: feedback?(emorley)
Comment 3•10 years ago
|
||
Comment on attachment 8592919 [details] [review]
refactor artifacts out of jobs model PR
I've only skim read it, since the diffs are pretty large, but I can't see anything obviously an issue :-)
Attachment #8592919 -
Flags: feedback?(emorley) → feedback+
Updated•10 years ago
|
Attachment #8592919 -
Flags: review?(mdoglio) → review+
Comment 4•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/44511e4518a7ede2fdc337311920a14e2d57dd65
Bug 1154470 - refactor artifact handling into its own model
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•